Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PA Waveform w/ Right Atrial Placement (CVP) Not Drawing/Scaling Correctly #205

Closed
tanjera opened this issue Jan 31, 2024 · 2 comments
Closed

PA Waveform w/ Right Atrial Placement (CVP) Not Drawing/Scaling Correctly #205

tanjera opened this issue Jan 31, 2024 · 2 comments
Assignees
@tanjera
Labels
bug clinical realism

Comments

@tanjera
Copy link
Owner

tanjera commented Jan 31, 2024

Different from #204 because the waveform is entirely mis-drawn

image

But can be fixed by adjusting PAS/PAD pressure variables... likely just drawing below visible area on the Strip and being scaled upwards (to higher pressure area of Strip) when pressure is increased.

Caused by Scale() function being invoked... is necessary because the PA strip is scalable (Fixed vs. Auto-Scale) whereas the CVP strip is not (default fixed).
@tanjera
Copy link
Owner Author

tanjera commented Jan 31, 2024

Determined due to https://github.com/tanjera/infirmary-integrated/blob/398336ba90c3de8df0010a07578c0313fbe65370/II%20Library/Classes/Waveform.Draw.cs#L152C7-L152C73
... instead of dampening the amplitude, it is reversing around the Y-axis; since most of the waveform is in the positive Y space, it is dropping off the negative scale.

Since this is the only implementation of DampenAmplitude_DiastolicFillTime receiving a non-default coefficient, and it is obviously problematic, am going to remove the non-default option from the constructor.

@tanjera tanjera self-assigned this Jan 31, 2024
tanjera added a commit that referenced this issue Jan 31, 2024
@tanjera
IISIM 2.5.8: Rhythm.Strip Debugging; Copyrights
da3493f 
- ReplaceAtOver() replaced w/ Replace() for CVP: #204
  - Also replaced w/ Replace() for PA @ RA (CVP)
- Tracing.CalculateOffsets() Offset.Y & Multiplier.Y utilizing Stretch technique
  - Keeps tracings centered on Strip's Y-axis; #206
- Fixed Draw.CVP_Rhythm -> DampenAmplitude_DiastolicFillTime coefficient of -1
  - Was flipping the tracing, causing #205
  - Since no other use of DampenAmplitude_DiastolicFillTime uses custom coefficient...
    - Custom coefficient removed from constructor
- Copyrights updated (2023 -> 2024)
  - In About dialog, on splash screen .png, in readme
@tanjera
Copy link
Owner Author

tanjera commented Jan 31, 2024

Fixed in da3493f

@tanjera tanjera closed this as completed Jan 31, 2024
@tanjera tanjera mentioned this issue Jan 31, 2024
Closed
4 tasks
tanjera added a commit that referenced this issue Feb 1, 2024
@tanjera
IISIM 2.5.9: CVP/PA Enhancements; Keyboard Shortcuts
a876fc4 
- PA placement in RA now takes PSP/PDP from CVP
  - Disables PSP/PDP input; re-enables if placement moved
  - PSP/PDP/CVP input minimums set to -20 for realism
- ReplaceAtOver utilized on CVP drawing (#205 was the problem, not #204)
- CVP default amplitude reduced for realism on fixed amplitude strips (CVP)
  - PA strip scales accordingly per fixed or auto scaling min/max
- Keyboard shortcuts implemented w/ MenuItem hints
  - Cardiac Monitor & Defibrillator implemented
    - Added Enable & Disable Audio MenuItems for convenience
    - Added #'s 1-8  for instantly setting # of numerics
    - Added #'s Ctrl+1-8  for instantly setting # of tracings
  - 12 Lead ECG & EFM & IABP keyboard shortcuts implemented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanjera tanjera

Labels
bug clinical realism
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tanjera