Proposal of fixes to Google Cloud Memorystore Memcached Operators #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobKed
changed the title
mik-laj
approved these changes
Oct 14, 2020
|
I made updates after comment googleapis/python-memcache#19 (comment) |
tanjinP
merged commit e7d3e3e
into
tanjinP:issue-8286-cloud-memorystore-memcached-operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made separate DAG for memcached.
Seems that there is problem with protobuf for memcached google api
I also struggle with making FieldMask updates to work (without success)
https://cloud.google.com/dialogflow/es/docs/how/field-mask
https://developers.google.com/google-ads/api/docs/client-libs/python/field-masks
https://github.com/googleapis/python-memcache/blob/v0.2.0/google/cloud/memcache_v1beta2/services/cloud_memcache/client.py