1.13 test fixes #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we changed this way back at fab634e for Rosie Pi and the merge mangled it. I think at this point it makes sense just to take upstream's version again.
This caused a build error with external native code, as MP_QSTR_protocol_stream was not available.
objtype.h got included twice, and vfs.h is unneeded.
.. this fixes the vfs_fat_ramdisk failure.
This fixes a fail in extra_coverage.py.
At least features0 works, and was useful in fixing the related native test
This example works, and was useful when fixing a native code test. Most of the other natmod examples do not work, however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, this gets through the first set of tests but has a bunch of failures on the async tests with--emit native. I'll continue to work on it.Now all the tests pass locally. There are some interesting differences between our
translate()and micropython'sMP_ERROR_TEXTthat create a barrier to many of the examples working; another problem has to do with the long-lived flag of the allocator.