SELECT * bug fixes #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanujnay112
approved these changes
Aug 14, 2020
tanujnay112
pushed a commit
that referenced
this pull request
Aug 24, 2020
* Hackathon: Position() string function added (#7) * Add Position logic in string_functions * Added function declaration and TPL bytecode for Postion * Added semantic checking/typing for Position * Changes to VM and bytecode generator for Position function * Added position function to catalog * Changes to get Position() working - with Junit test * Missing Junit test changes * Fixed format errors * Use custom search function to avoid copying the strings Co-authored-by: Abhijith Anilkumar <abhijithanilkumar@live.com> Co-authored-by: Arvind Sai Krishnan <arvindsk@andrew.cmu.edu> (cherry picked from commit 5da6124) * Fix StringFunctions::Position (cherry picked from commit 55a2a10) * Update position bytecode generator * Fix broken tests * Add position test traces * The ASCII function returns the ascii value of the first character in the string that is passed into it. This commit includes implementation (in string_functions and built-in specification files), integration (in database_catalog), a C++ test (in string_functions_test), and a Junit test (in FunctionsTest). * Recommended fixes to implementation * Update emitter and str length functions for ascii * chr * builtin * fixed chr * fixed bytes * exp * charlength * c++ test * Update emitter func and remove dup vars * Fix order of OpCharLength call * Set return type of builtin string functions * Format code and fix tests * Add test traces for exp, ascii, chr, char_length * Fix formatting and ordering * Remove comment * Refactor string function signatures * Organize pg_proc numbers * Fix typo * Organize pg_proc ids * Fix format * Fix pg_proc ids * Change type of Builtin enum from uint8_t to uint16_t * Remove uneccessary calls to Resolve * Format code blocks * Remove redundant null checks * Fix comments Co-authored-by: Andy Pavlo <pavlo@cs.brown.edu> Co-authored-by: Paulina Davison <pldaviso@andrew.cmu.edu> Co-authored-by: YingjingLu <yingjinglu2019us@gmail.com> Co-authored-by: wuwenw <wuwenw@andrew.cmu.edu> Co-authored-by: Matt Butrovich <mbutrovich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.