Disable misc-include-cleaner for now

taocpp · Nov 16, 2024 · b8b7e1c · b8b7e1c
1 parent a89a2fb
commit b8b7e1c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.clang-tidy b/.clang-tidy
@@ -5,6 +5,11 @@
 # Distributed under the Boost Software License, Version 1.0.
 # (See accompanying file LICENSE_1_0.txt or copy at https://www.boost.org/LICENSE_1_0.txt)
 
+# Note: The misc-include-cleaner is generally useful,
+# but produces false positives with Oid/InvalidOid and libpq-fe.h.
+# For that reason it is disabled, but it should be enabled
+# manually from time to time.
+
 Checks: >-
   bugprone-*,
   -bugprone-easily-swappable-parameters,
@@ -19,6 +24,7 @@ Checks: >-
   misc-*,
   -misc-non-private-member-variables-in-classes,
   -misc-unused-alias-decls,
+  -misc-include-cleaner,
   modernize-*,
   -modernize-avoid-c-arrays,
   -modernize-concat-nested-namespaces,

diff --git a/include/tao/pq/oid.hpp b/include/tao/pq/oid.hpp
@@ -5,7 +5,7 @@
 #ifndef TAO_PQ_OID_HPP
 #define TAO_PQ_OID_HPP
 
-#include <libpq-fe.h>  // NOLINT(misc-include-cleaner)
+#include <libpq-fe.h>
 
 namespace tao::pq
 {