Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs: call to undefined addEventListener causing problems #448

Closed
bwalex opened this issue Jun 30, 2024 · 2 comments
Closed

nodejs: call to undefined addEventListener causing problems #448

bwalex opened this issue Jun 30, 2024 · 2 comments
Labels
pull requests welcome

Comments

@bwalex
Copy link

bwalex commented Jun 30, 2024 •
edited
Loading

sente/src/taoensso/sente.cljc

Line 1353 in 102c5b0

(.addEventListener goog/global "beforeunload"

This bit of code unconditionally calls the global addEventListener in all ClojureScript environments, including node.js. I use Sente as a server in a nodejs environment, all compiled with shadow-cljs - if that makes any difference. I'm currently on 1.16.2, and tried to update to 1.19.2, which is how I ran into it.
@ptaoussanis
Copy link
Member

@bwalex Hi Alex- thanks for the report. PR welcome to exclude this behaviour from Node.js, otherwise I'll take care of this next time I'm on batched Sente work 👍

@ptaoussanis
Copy link
Member

I believe this should be addressed by #453, which I'm merging now

ptaoussanis pushed a commit that referenced this issue Oct 28, 2024
@theasp @ptaoussanis
[fix] [#448] [#453] Don't add beforeunload event listener when runn…
dc6b34e 
…ing inside NodeJS (@theasp)

This solves this problem:
```
SHADOW import error /home/asp/projects/xxx/.shadow-cljs/builds/server/dev/out/cljs-runtime/taoensso.sente.js

/home/asp/projects/xxx/target/private/js/server.js:64
  /* ignore this, look at stacktrace */ fn.call(global, require, module, __filename, __dirname);
                                           ^
TypeError: goog.global.addEventListener is not a function
    at /home/asp/projects/xxx/.shadow-cljs/builds/server/dev/out/cljs-runtime/taoensso/sente.cljc:1353:4
    at global.SHADOW_IMPORT (/home/asp/projects/xxx/target/private/js/server.js:64:44)
    at /home/asp/projects/xxx/target/private/js/server.js:1624:1
    at Object.<anonymous> (/home/asp/projects/xxx/target/private/js/server.js:1638:3)
    at Module._compile (node:internal/modules/cjs/loader:1233:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1287:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Function.Module._load (node:internal/modules/cjs/loader:938:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
    at node:internal/main/run_main_module:23:47
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pull requests welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptaoussanis @bwalex