Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up handshake-user-data from websocket message into :chsk/state #111

Closed
wants to merge 4 commits into from
Closed

Conversation

whodidthis
Copy link
Contributor

@ptaoussanis
Copy link
Member

Hey there,

What's your motivation for this? Any reason you wouldn't just watch the :chsk/handshake event for this data?

@whodidthis
Copy link
Contributor Author

Sorry, I've not seen a :chsk/handshake coming from ch-recv at least. Just tried the example project. I might be confused about some stuff again, where should I find it?

@ptaoussanis
Copy link
Member

Sorry, I've not seen a :chsk/handshake coming from ch-recv at least

Aha, that's because it won't! My mistake, thought it would :-)

Your solution seems reasonable but would like to sleep on it. Will get back to you about this.

@whodidthis
Copy link
Contributor Author

Oh, yeah just looked at the source again and it's there https://github.com/ptaoussanis/sente/blob/dev/src/taoensso/sente.cljx#L28. I guess it's currently like :chsk/ws-ping in that it isn't put! into ch-recv. I'm all for not merging handshake-user-data into chsk-state if I can handle :chsk/handshake myself. 👍

@ptaoussanis
Copy link
Member

Okay, have just updated [com.taoensso/sente "1.4.0-SNAPSHOT"] on Clojars. This should put :chsk/handshake evs to your client-side ch-recv as originally intended.

Details in the dev changelog.

Please let me know how this one goes?

Cheers! :-)

@ptaoussanis
Copy link
Member

Just pushed [com.taoensso/sente "1.4.0-beta1"] to Clojars. Closing for now, feel free to reopen if you run into any issues.

@ptaoussanis ptaoussanis closed this Mar 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants