[fix] [#365] Provide protection against faulty error-fn

taoensso · Feb 27, 2023 · 39e670a · 39e670a
1 parent 63712c5
commit 39e670a
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/taoensso/timbre.cljc b/src/taoensso/timbre.cljc
@@ -412,8 +412,13 @@
        (when-let [err ?err]
          (when-let [ef (get output-opts :error-fn default-output-error-fn)]
            (when-not   (get output-opts :no-stacktrace?) ; Back compatibility
-             (str enc/system-newline
-               (ef data)))))))))
+             (enc/catching
+               (str enc/system-newline (ef data)) _
+               (str
+                 enc/system-newline
+                 "[TIMBRE WARNING]: `error-fn` failed, falling back to `pr-str`:"
+                 enc/system-newline
+                 (enc/catching (pr-str err) _ "<pr-str failed>"))))))))))
 
 (defn- default-arg->str-fn [x]
   (enc/cond