Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shutdown-agents shutdown hook breaks other shutdown hooks #127

Closed
hadronzoo opened this issue Aug 15, 2015 · 2 comments
Closed

shutdown-agents shutdown hook breaks other shutdown hooks #127

hadronzoo opened this issue Aug 15, 2015 · 2 comments

Comments

@hadronzoo
Copy link

Since shutdown hooks run concurrently, running (shutdown-agents) within a shutdown hook will break other shutdown hooks that rely on agents. For example, logging, releasing datomic connection resources, or shutting down an http-kit server within other shutdown hooks will non-deterministically throw exceptions if shutdown-agents has already executed.

Can this experimental shutdown hook be opt-in?

@ptaoussanis
Copy link
Member

Hi Joshua, thanks a lot for the report (and reference)! Have cut a 4.1.1 release that removes the experimental hook.

@hadronzoo
Copy link
Author

Excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants