Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect :fmt-output-opts by using the system's output instead of hand-rolling it #50

Merged
merged 2 commits into from
Feb 22, 2014

Conversation

kenrestivo
Copy link

The rotor appender was not respecting :fmt-output-opts because it was hand-rolling its own formatting instead of using the output that is already handed to it, with stacktraces already pre-formatted. Rotor was dumping unreadable stacktraces that looked like this:

https://www.refheap.com/44858

This patch is required in order for options passed to the stacktrace via :fmt-output-opts to work, and so that configs like this will work:

  (log/set-config! [:appenders :rotor] (assoc rotor/rotor-appender
                                          :fmt-output-opts {:nofonts? true}))

@kenrestivo
Copy link
Author

There's also another minor cleanup in the rolling appender included in this patchset, which could be cherrypicked out if needed.

@ptaoussanis
Copy link
Member

This looks good Ken, thanks!

ptaoussanis added a commit that referenced this pull request Feb 22, 2014
Rotor appender: respect :fmt-output-opts by using the system's output instead of hand-rolling it
@ptaoussanis ptaoussanis merged commit 0a7ccc9 into taoensso:master Feb 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants