-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements TAP TODO directive #254
Conversation
Please revert all the whitespace changes - that's a part of this project's style. |
@ronkorving wrt test/comment.js failing - what version of node are you using? It passes for me on my OSX machine. |
I've tried on both Node 4.3.0 and 5.6.0, and comment.js fails. I'll make a separate issue in a bit. (update: see #255) Re. whitespace, it may be useful then to add a http://editorconfig.org file. That would make it much easier to contribute. |
422ce91
to
abc2720
Compare
All whitespace changes have been reverted. |
As mentioned in #219 , a very warm and welcome +1 for this. |
(fixed the test/comment.js tests in 40be685 btw) |
Appreciated :) (to both of you) |
Shouldn't you also add a |
test/todo.js
Outdated
) | ||
})); | ||
|
||
test("success", function (t) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please stick with single-quoted strings, for consistency (same below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happily :) I think I saw some test names with double quotes elsewhere so kinda went with that. Wasn't really sure what was expected tbh.
+1 on |
👍 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1d60924
to
5cdaf54
Compare
[New] Implements TAP TODO directive (#254) [New] add alias 'notDeepEquals' to 'notDeepEqual' function (#411) [Fix] fix premature end of tests (and running sibling tests) when test includes subtests (#403, #222) [Fix] only use one test runner for results, even if multiple streams are created (#404, #361, #105) [Fix] windows: Show failure location even if driver letter is lowercase (#329) [Docs] link to mixed tape (#445) [Docs] Add electron-tap (#240) [Docs] Add tape-promise into 'other' (#210) [Docs] Mention [`flip-tape`](https://github.com/pguth/flip-tape/blob/master/README.md) in the section "other". (#359) [Docs] Add an alternative ES6 tape runner (#328)
Closes #219 as discussed with @awlayton