Preserve stacktraces for async/await #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Dec 31, 2020
|
Addressed feedback. |
ljharb
reviewed
Jan 2, 2021
ljharb
force-pushed
the
rejection-stacktrace
branch
from
d816458 to
a2128b1
Compare
|
Cleaned up the test, this looks good to merge to me. |
|
I’m going to land #538 first and rebase this, so i can be sure tests pass in all relevant node versions, and then I’ll land this one. |
ljharb
force-pushed
the
rejection-stacktrace
branch
from
3c81294 to
cb5d7fd
Compare
ljharb
approved these changes
Jan 3, 2021
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
==========================================
- Coverage 73.87% 73.84% -0.03%
==========================================
Files 19 19
Lines 754 757 +3
Branches 145 146 +1
==========================================
+ Hits 557 559 +2
- Misses 197 198 +1
Continue to review full report at Codecov.
|
ljharb
force-pushed
the
rejection-stacktrace
branch
from
cb5d7fd to
3325344
Compare
|
I'll fix these last failing tests, and land this tonight. |
ljharb
force-pushed
the
rejection-stacktrace
branch
from
3325344 to
d505cdf
Compare
ljharb
added a commit
that referenced
this pull request
Jan 4, 2021
- [Fix] preserve stack traces for returned Promises (async/await) (#537) - [Robustness] cache and call-bind more prototype methods - [Refactor] use `call-bind/callBound` instead of `function-bind` directly - [readme] Document unexpected `t.end()` behavior (#279) - [readme] Added tabe into reporter list (#249) - [readme] improve method docs - [meta] do not publish github action workflow files - [meta] run `aud` in `posttest` - [meta] add Automatic Rebase and Require Allow Edits workflows - [eslint] ensure no trailing commas - [eslint] fix some inconsistencies - [Tests] make `stripFullStack` output an array of lines, for better failure messages - [Tests] add `npm run test:example` to test non-failing examples. - [Tests] migrate tests to Github Actions (#538) - [Tests] skip Promise tests when Promises are not available - [Tests] run `nyc` on all tests - [Tests] add `timeoutAfter` test with Promises
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
self.ifError(err)instead ofself.fail()which logs the original stacktrace instead of creating
a new Error object.
Fixes #536