stream locking #576
Draft
stream locking #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
==========================================
- Coverage 96.36% 95.14% -1.22%
==========================================
Files 4 4
Lines 632 639 +7
Branches 148 148
==========================================
- Hits 609 608 -1
- Misses 23 31 +8
Continue to review full report at Codecov.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #576 +/- ##
==========================================
- Coverage 96.76% 95.72% -1.04%
==========================================
Files 4 4
Lines 742 749 +7
Branches 182 182
==========================================
- Hits 718 717 -1
- Misses 24 32 +8 ☔ View full report in Codecov by Sentry. |
ljharb
reviewed
Jan 10, 2024
Comment on lines
+150
to
152
| run(); | ||
|
|
||
| if (wait) { |
There was a problem hiding this comment.
does this change mean it's breaking for anyone using wait?
ljharb
force-pushed
the
master
branch
3 times, most recently
from
c16dde3
to
2ad86d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
wait,runcalls to enable use with object mode streams and asynchronous module loading.fix #575 close #575