Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispatcher Provider #29

Merged
merged 4 commits into from
Mar 14, 2023
Merged

Dispatcher Provider #29

merged 4 commits into from
Mar 14, 2023

Conversation

greenfodor
Copy link
Collaborator

@greenfodor greenfodor commented Feb 16, 2023 •
edited
Loading

Resolves #21

@greenfodor greenfodor linked an issue Feb 16, 2023 that may be closed by this pull request
Create a DispatcherProvider class that can be injected and provide the right coroutine dispatcher #21
Closed
@greenfodor greenfodor self-assigned this Feb 16, 2023
@greenfodor greenfodor added this to the Version 1.1 milestone Feb 16, 2023
@greenfodor greenfodor added the enhancement New feature or request label Feb 16, 2023
ateslovan
ateslovan approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@ateslovan ateslovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . We just need to solve conflicts now that the migration to compose is merged.

@greenfodor greenfodor merged commit 7124789 into develop Mar 14, 2023
@greenfodor greenfodor deleted the feature/dispatcher-provider branch March 14, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreealaura16 andreealaura16 andreealaura16 approved these changes

@alexhasmasan alexhasmasan alexhasmasan approved these changes

@ateslovan ateslovan ateslovan approved these changes

@laurentiuonac laurentiuonac Awaiting requested review from laurentiuonac

@catadarjan-tapptitude catadarjan-tapptitude Awaiting requested review from catadarjan-tapptitude

@alex-dani alex-dani Awaiting requested review from alex-dani

@cristidregan cristidregan Awaiting requested review from cristidregan

@flaviu-crisan-olimpiu flaviu-crisan-olimpiu Awaiting requested review from flaviu-crisan-olimpiu

@hdralexandru hdralexandru Awaiting requested review from hdralexandru

@iuliabirsan iuliabirsan Awaiting requested review from iuliabirsan

@popalexcristian popalexcristian Awaiting requested review from popalexcristian

@StanciuGeorgi StanciuGeorgi Awaiting requested review from StanciuGeorgi

Assignees

@greenfodor greenfodor

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 1.1
Development

Successfully merging this pull request may close these issues.

Create a DispatcherProvider class that can be injected and provide the right coroutine dispatcher
5 participants
@greenfodor @ateslovan @alexhasmasan @andreealaura16 @georgefodor-tapp