-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Copy the content of
sharding_key.lua file to `sharding_metadata.lua…
…` file PR #181 introduced support of DDL sharding keys. Implementation of sharding keys support contains methods that are common to support sharding keys and sharding functions. That's why a separate file `sharding_metadata.lua` was created to contain common methods. In this commit content of `sharding_key.lua` file is coppied to `sharding_metadata.lua` file to simplify a reviewer's life and display the history of changes relative to PR #181 in the following commits. Part of #237
- Loading branch information
Showing
8 changed files
with
155 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,142 @@ | ||
| local fiber = require('fiber') | ||
| local errors = require('errors') | ||
|
|
||
| local call = require('crud.common.call') | ||
| local const = require('crud.common.const') | ||
| local dev_checks = require('crud.common.dev_checks') | ||
| local cache = require('crud.common.sharding_key_cache') | ||
|
|
||
| local FetchShardingKeyError = errors.new_class('FetchShardingKeyError', {capture_stack = false}) | ||
|
|
||
| local FETCH_FUNC_NAME = '_crud.fetch_on_storage' | ||
|
|
||
| local sharding_key_module = {} | ||
|
|
||
| -- Function decorator that is used to prevent _fetch_on_router() from being | ||
| -- called concurrently by different fibers. | ||
| local function locked(f) | ||
| dev_checks('function') | ||
|
|
||
| return function(timeout, ...) | ||
| local timeout_deadline = fiber.clock() + timeout | ||
| local ok = cache.fetch_lock:put(true, timeout) | ||
| -- channel:put() returns false in two cases: when timeout is exceeded | ||
| -- or channel has been closed. However error message describes only | ||
| -- first reason, I'm not sure we need to disclose to users such details | ||
| -- like problems with synchronization objects. | ||
| if not ok then | ||
| return FetchShardingKeyError:new( | ||
| "Timeout for fetching sharding key is exceeded") | ||
| end | ||
| local timeout = timeout_deadline - fiber.clock() | ||
| local status, err = pcall(f, timeout, ...) | ||
| cache.fetch_lock:get() | ||
| if not status or err ~= nil then | ||
| return err | ||
| end | ||
| end | ||
| end | ||
|
|
||
| -- Return a map with metadata or nil when space box.space._ddl_sharding_key is | ||
| -- not available on storage. | ||
| function sharding_key_module.fetch_on_storage() | ||
| local sharding_key_space = box.space._ddl_sharding_key | ||
| if sharding_key_space == nil then | ||
| return nil | ||
| end | ||
|
|
||
| local SPACE_NAME_FIELDNO = 1 | ||
| local SPACE_SHARDING_KEY_FIELDNO = 2 | ||
| local metadata_map = {} | ||
| for _, tuple in sharding_key_space:pairs() do | ||
| local space_name = tuple[SPACE_NAME_FIELDNO] | ||
| local sharding_key_def = tuple[SPACE_SHARDING_KEY_FIELDNO] | ||
| local space_format = box.space[space_name]:format() | ||
| metadata_map[space_name] = { | ||
| sharding_key_def = sharding_key_def, | ||
| space_format = space_format, | ||
| } | ||
| end | ||
|
|
||
| return metadata_map | ||
| end | ||
|
|
||
| -- Under high load we may get a case when more than one fiber will fetch | ||
| -- metadata from storages. It is not good from performance point of view. | ||
| -- locked() wraps a _fetch_on_router() to limit a number of fibers that fetches | ||
| -- a sharding metadata by a single one, other fibers will wait while | ||
| -- cache.fetch_lock become unlocked during timeout passed to | ||
| -- _fetch_on_router(). | ||
| local _fetch_on_router = locked(function(timeout) | ||
| dev_checks('number') | ||
|
|
||
| if cache.sharding_key_as_index_obj_map ~= nil then | ||
| return | ||
| end | ||
|
|
||
| local metadata_map, err = call.any(FETCH_FUNC_NAME, {}, { | ||
| timeout = timeout | ||
| }) | ||
| if err ~= nil then | ||
| return err | ||
| end | ||
| if metadata_map == nil then | ||
| cache.sharding_key_as_index_obj_map = {} | ||
| return | ||
| end | ||
|
|
||
| cache.sharding_key_as_index_obj_map = {} | ||
| for space_name, metadata in pairs(metadata_map) do | ||
| local sharding_key_as_index_obj, err = as_index_object(space_name, | ||
| metadata.space_format, | ||
| metadata.sharding_key_def) | ||
| if err ~= nil then | ||
| return err | ||
| end | ||
| cache.sharding_key_as_index_obj_map[space_name] = sharding_key_as_index_obj | ||
| end | ||
| end) | ||
|
|
||
| -- Get sharding index for a certain space. | ||
| -- | ||
| -- Return: | ||
| -- - sharding key as index object, when sharding key definition found on | ||
| -- storage. | ||
| -- - nil, when sharding key definition was not found on storage. Pay attention | ||
| -- that nil without error is a successfull return value. | ||
| -- - nil and error, when something goes wrong on fetching attempt. | ||
| -- | ||
| function sharding_key_module.fetch_on_router(space_name, timeout) | ||
| dev_checks('string', '?number') | ||
|
|
||
| if cache.sharding_key_as_index_obj_map ~= nil then | ||
| return cache.sharding_key_as_index_obj_map[space_name] | ||
| end | ||
|
|
||
| local timeout = timeout or const.FETCH_SHARDING_KEY_TIMEOUT | ||
| local err = _fetch_on_router(timeout) | ||
| if err ~= nil then | ||
| if cache.sharding_key_as_index_obj_map ~= nil then | ||
| return cache.sharding_key_as_index_obj_map[space_name] | ||
| end | ||
| return nil, err | ||
| end | ||
|
|
||
| if cache.sharding_key_as_index_obj_map ~= nil then | ||
| return cache.sharding_key_as_index_obj_map[space_name] | ||
| end | ||
|
|
||
| return nil, FetchShardingKeyError:new( | ||
| "Fetching sharding key for space '%s' is failed", space_name) | ||
| end | ||
|
|
||
| function sharding_key_module.update_cache(space_name) | ||
| cache.drop_caches() | ||
| return sharding_key_module.fetch_on_router(space_name) | ||
| end | ||
|
|
||
| function sharding_key_module.init() | ||
| _G._crud.fetch_on_storage = sharding_key_module.fetch_on_storage | ||
| end | ||
|
|
||
| return sharding_key_module |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 3 additions & 2 deletions
5
test/unit/sharding_key_test.lua → test/unit/sharding_metadata_test.lua
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters