Reload sharding data #268
Merged
Reload sharding data #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferentialOrange
changed the title
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-212-reload-sharding-keys
branch
from
4381677 to
67da2cf
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-212-reload-sharding-keys
branch
10 times, most recently
from
8f5ca7c to
18657b4
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-212-reload-sharding-keys
branch
from
18657b4 to
ce8b497
Compare
Bump `cartridge` rock dependency to 2.7.4 in tests. Version 2.7.4 fixes critical bug related to cartridge hot reload killing `box.watchable` fiber and causing Tarantool to segfault [1]. 1. tarantool/cartridge#1741
If crud request uses tuple as input argument (insert, upsert and replace operations) and its bucket_id is empty, the module will fill this field and damage input argument tuple. This patch fixes this behavior. After this patch, performance of insert, upsert and replace has decreased by 5%. Part of #212
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-212-reload-sharding-keys
branch
from
ce8b497 to
6aaa008
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-212-reload-sharding-keys
branch
3 times, most recently
from
2ba2e2c to
544618a
Compare
Totktonada
reviewed
Apr 18, 2022
Totktonada
reviewed
Apr 18, 2022
Totktonada
reviewed
Apr 18, 2022
Totktonada
reviewed
Apr 18, 2022
Totktonada
reviewed
Apr 18, 2022
Totktonada
reviewed
Apr 18, 2022
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-212-reload-sharding-keys
branch
2 times, most recently
from
128a338 to
2053ff8
Compare
|
I have responded to all current comments with comment, fix or both. |
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-212-reload-sharding-keys
branch
from
2053ff8 to
f28a4c7
Compare
Totktonada
reviewed
Apr 19, 2022
Totktonada
approved these changes
Apr 19, 2022
There was a problem hiding this comment.
Thanks for the patchset!
I have no objections (aside of several nits above). Feel free to merge.
I think that we should revisit our implementation of schema reloading in a future and make it less coupled with other logic. So I assigned #253 to you as the first step into this direction.
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-212-reload-sharding-keys
branch
from
f28a4c7 to
ccb467d
Compare
Compute and store sharding key and sharding func hashes on storages. Hashes are updated with on_replace triggers. Part of #212
Rename sharding_metadata_cache to router_metadata_cache to distinct it from storage_metadata_hash. Part of #212
Fetch sharding info hashes to router on ddl schema load. Hashes are stored in router metadata cache together with sharding info. Part of #212
Return error if router sharding info differs from storage sharding info. Comparison is based on sharding hash values. Hashes are provided with each relevant request. Hashes are extracted together with sharding key and sharding func definitions on router during request execution. After this patch, the performance of insert requests decreased by 5%, the performance of select requests decreased by 1.5%. Part of #212
If sharding info mismatch has happened, sharding info will be reloaded on router. After that, request will be retried with new sharding info (expect for pairs requests due to its nature, they must be retried manually). There are no detectable performance drops introduced in this patch. Closes #212
Since sharding schema reloads must be processed automatically after this patchset, there shouldn't be usual cases where user need to reload sharding info manually. Thus methods for manual sharding schema reload are deprecated and will be removed in future releases. Follows up #212
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-212-reload-sharding-keys
branch
from
ccb467d to
b751c96
Compare
DifferentialOrange
deleted the
DifferentialOrange/gh-212-reload-sharding-keys
branch
Merged
DifferentialOrange
added a commit
that referenced
this pull request
May 6, 2022
After introducing sharding hash info comparison [1], requests with ddl and explicit bucket_id in options started to fail with "Sharding hash mismatch" error. It affected following methods: - insert - insert_object - replace - replace_object - upsert - upsert_object - count The situation is as follows. Due to a code mistake, router hasn't passed a sharding hash with a request if bucket_id was specified. If there was any ddl information for a space on storage, it has caused a hash mismatch error. Since sharding info reload couldn't fix broken hash extraction, request failed after a number of retries. This patch fixes this behavior by skipping hash comparison if sharding info wasn't used (we already do it in other methods). 1. #268 Closes #278
DifferentialOrange
added a commit
that referenced
this pull request
May 6, 2022
After introducing sharding hash info comparison [1], requests with ddl and explicit bucket_id in options started to fail with "Sharding hash mismatch" error. It affected following methods: - insert - insert_object - replace - replace_object - upsert - upsert_object - count The situation is as follows. Due to a code mistake, router hasn't passed a sharding hash with a request if bucket_id was specified. If there was any ddl information for a space on storage, it has caused a hash mismatch error. Since sharding info reload couldn't fix broken hash extraction, request failed after a number of retries. This patch fixes this behavior by skipping hash comparison if sharding info wasn't used (we already do it in other methods). 1. #268 Closes #278
DifferentialOrange
added a commit
that referenced
this pull request
May 6, 2022
After introducing sharding hash info comparison [1], requests with ddl and explicit bucket_id in options started to fail with "Sharding hash mismatch" error. It affected following methods: - insert - insert_object - replace - replace_object - upsert - upsert_object - count The situation is as follows. Due to a code mistake, router hasn't passed a sharding hash with a request if bucket_id was specified. If there was any ddl information for a space on storage, it has caused a hash mismatch error. Since sharding info reload couldn't fix broken hash extraction, request failed after a number of retries. This patch fixes this behavior by skipping hash comparison if sharding info wasn't used (we already do it in other methods). 1. #268 Closes #278
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deps: bump cartridge dependency
Bump
cartridgerock dependency to 2.7.4 in tests. Version 2.7.4 fixescritical bug related to cartridge hot reload killing
box.watchablefiber and causing Tarantool to segfault [1].
crud: do not change input tuple object
If crud request uses tuple as input argument (insert, upsert and replace
operations) and its bucket_id is empty, the module will fill this field
and damage input argument tuple. This patch fixes this behavior.
After this patch, performance of insert, upsert and replace has
decreased by 5%.
ddl: store sharding info hashes on storage
Compute and store sharding key and sharding func hashes on storages.
Hashes are updated with on_replace triggers.
ddl: rename sharding_metadata_cache
Rename sharding_metadata_cache to router_metadata_cache to distinct it
from storage_metadata_hash.
ddl: fetch sharding info hashes to router
Fetch sharding info hashes to router on ddl schema load. Hashes are
stored in router metadata cache together with sharding info.
ddl: fail on sharding info mismatch
Return error if router sharding info differs from storage sharding info.
Comparison is based on sharding hash values. Hashes are provided with
each relevant request.
Hashes are extracted together with sharding key and sharding func
definitions on router during request execution.
After this patch, the performance of insert requests decreased by 5%,
the performance of select requests decreased by 1.5%.
ddl: reload and retry on sharding info mismatch
If sharding info mismatch has happened, sharding info will be reloaded
on router. After that, request will be retried with new sharding info
(expect for pairs requests due to its nature, they must be retried
manually).
There are no detectable performance drops introduced in this patch.
ddl: deprecate manual sharding schema reload
Since sharding schema reloads must be processed automatically after this
patchset, there shouldn't be usual cases where user need to reload
sharding info manually. Thus methods for manual sharding schema reload
are deprecated and will be removed in future releases.
I didn't forget about
Closes #212