Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: describe schema reload implementation #317

Merged
merged 1 commit into from
Aug 17, 2022
Merged

doc: describe schema reload implementation #317

merged 1 commit into from
Aug 17, 2022

Conversation

DifferentialOrange
Copy link
Member

This patch adds a small document describing how space and sharding schemas works in the module. It covers what schemas are, how we store, use and reload them in requests.

I didn't forget about

  • Tests (not required)
  • Changelog (since it's internal, I don't think it's worth it)
  • Documentation

Closes #253

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-253-design-doc-reload branch from 2ce9fe6 to e381557 Compare August 3, 2022 16:06
Totktonada
Totktonada reviewed Aug 11, 2022
View reviewed changes
Totktonada
Totktonada reviewed Aug 11, 2022
View reviewed changes
Totktonada
Totktonada reviewed Aug 11, 2022
View reviewed changes
Totktonada
Totktonada reviewed Aug 11, 2022
View reviewed changes
Totktonada
Totktonada reviewed Aug 11, 2022
View reviewed changes
Totktonada
Totktonada reviewed Aug 11, 2022
View reviewed changes
Totktonada
Totktonada reviewed Aug 11, 2022
View reviewed changes
Totktonada
Totktonada reviewed Aug 11, 2022
View reviewed changes
Totktonada
Totktonada reviewed Aug 11, 2022
View reviewed changes
Totktonada
Totktonada approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the document! I left several comments, but in general it looks okay for me.

If you have thoughts how this code can be reorganized to be less intrusive and easier to understand, it is okay to include the ideas into the document as well.

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-253-design-doc-reload branch 4 times, most recently from 1207c1d to 099f6ab Compare August 12, 2022 15:26
Totktonada
Totktonada reviewed Aug 12, 2022
View reviewed changes
Totktonada
Totktonada reviewed Aug 12, 2022
View reviewed changes
Totktonada
Totktonada reviewed Aug 12, 2022
View reviewed changes
Totktonada
Totktonada reviewed Aug 12, 2022
View reviewed changes
Totktonada
Totktonada reviewed Aug 12, 2022
View reviewed changes
Totktonada
Totktonada reviewed Aug 12, 2022
View reviewed changes
Totktonada
Totktonada reviewed Aug 12, 2022
View reviewed changes
Totktonada
Totktonada reviewed Aug 12, 2022
View reviewed changes
Totktonada
Totktonada reviewed Aug 12, 2022
View reviewed changes
Totktonada
Totktonada reviewed Aug 12, 2022
View reviewed changes
Totktonada
Totktonada reviewed Aug 12, 2022
View reviewed changes
Totktonada
Totktonada reviewed Aug 12, 2022
View reviewed changes
Totktonada
Totktonada requested changes Aug 12, 2022
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! You have added more details and now not everything looks obvious for me. So I take back my approve back and will continue to look into the document with you.

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-253-design-doc-reload branch 4 times, most recently from f37ffab to 724604e Compare August 15, 2022 08:41
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-253-design-doc-reload branch 2 times, most recently from f6a4f9f to 5061fe8 Compare August 15, 2022 13:46
@DifferentialOrange DifferentialOrange mentioned this pull request Aug 16, 2022
Merged
3 tasks
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-253-design-doc-reload branch from 5061fe8 to f707f65 Compare August 16, 2022 15:09
Totktonada
Totktonada approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the careful work!

@DifferentialOrange
doc: describe schema reload implementation
b7ca5c9 
This patch adds a small document describing how space and sharding
schemas works in the module. It covers what schemas are, how we store,
use and reload them in requests.

Closes #253
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-253-design-doc-reload branch from f707f65 to b7ca5c9 Compare August 17, 2022 08:54
@DifferentialOrange DifferentialOrange merged commit ddfc251 into master Aug 17, 2022
@DifferentialOrange DifferentialOrange deleted the DifferentialOrange/gh-253-design-doc-reload branch August 17, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Totktonada Totktonada Totktonada approved these changes

@AnaNek AnaNek AnaNek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

design document: how database schema information is renewed
3 participants
@DifferentialOrange @Totktonada @AnaNek