feature: master presence check with timeout #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GRISHNOV
force-pushed
the
igrishnov/gh-95-master-timeout-fetch-for-get-space-utils
branch
from
73e03ae to
54efec8
Compare
|
I did a rebase with master and also corrected the timeout condition AFAIU, it is enough to check during the timeout whether the master appeared in the replicaset after another |
GRISHNOV
force-pushed
the
igrishnov/gh-95-master-timeout-fetch-for-get-space-utils
branch
from
54efec8 to
a6f23cb
Compare
GRISHNOV
changed the title
GRISHNOV
changed the title
GRISHNOV
force-pushed
the
igrishnov/gh-95-master-timeout-fetch-for-get-space-utils
branch
from
a6f23cb to
9b86add
Compare
GRISHNOV
force-pushed
the
igrishnov/gh-95-master-timeout-fetch-for-get-space-utils
branch
from
9b86add to
00fcbfb
Compare
DifferentialOrange
approved these changes
Jan 27, 2023
There was a problem hiding this comment.
Seems fine. Did you've discussed anything with @Totktonada about subtraction?
Added timeout condition for the validation of master presence in replicaset and for the master connection to the `utils.get_space` method. Closes #95
GRISHNOV
force-pushed
the
igrishnov/gh-95-master-timeout-fetch-for-get-space-utils
branch
from
00fcbfb to
3858db9
Compare
Yes, I have discussed the current solution, it looks ok |
DifferentialOrange
deleted the
igrishnov/gh-95-master-timeout-fetch-for-get-space-utils
branch
DifferentialOrange
added a commit
that referenced
this pull request
Feb 2, 2023
Overview
This release introduces a breaking change with removing a deprecated
feature: `crud.len(space_id)`.
This release also introduces a Cartridge clusterwide config to setup
`crud.cfg`.
Breaking changes
You cannot use space id as a space identifier in `crud.len` anymore.
Use space name instead.
New features
* Timeout condition for the validation of master presence in
replicaset and for the master connection (#95).
* Cartridge clusterwide configuration for `crud.cfg` (#332).
Changes
* Forbid using space id in `crud.len` (#255).
Fixes
* Add validation of the master presence in replicaset and the
master connection to the `utils.get_space` method before
receiving the space from the connection (#331).
* Fix fiber cancel on schema reload timeout in `call_reload_schema`
(PR #337).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added timeout condition for the validation of master presence in replicaset and for the master connection to the
utils.get_spacemethod.Closes #95