coverage: fix dkjson install #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkjson rocks are installed by downloading some author-hosted tar.gz source archives. It seems that 2.5-2 version archive has been removed. (It's not available, yet 2.8-1 is ok.) We also change rockspec source to luarocks in the commit since GitHub repository for dkjson is archived since 2020 [1] while luarocks page is alive and receives new updates [2]. 1. https://github.com/LuaDist/dkjson 2. https://luarocks.org/modules/dhkolf/dkjson
DifferentialOrange
requested review from
oleg-jukovec and
better0fdead
and removed request for
oleg-jukovec and
better0fdead
readview test select fails on master luatest [1]. 1. https://github.com/tarantool/crud/actions/runs/9742871447/job/26885075515?pr=441
better0fdead
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dkjson rocks are installed by downloading some author-hosted tar.gz source archives. It seems that 2.5-2 version archive has been removed. (It's not available, yet 2.8-1 is ok.) We also change rockspec source to luarocks in the commit since GitHub repository for dkjson is archived since 2020 [1] while luarocks page is alive and receives new updates [2].