adding delete limit support #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kryvashek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This patch adds support for LIMIT clause in DELETE statements.
What changes are included in this PR?
This patch changes plan for delete statements from "DML <- Table Scan" into "DML <- Limit <- Table Scan" when a LIMIT clause was provided in the DELETE statement.
Are these changes tested?
Changes were tested manually and also a related test was added into
datafusion/sql/tests/sql_integration.rs.Are there any user-facing changes?
Yes, there are. But they are not breaking (unless someone was using LIMIT clause in a DELETE statement to intentionally get an error).