feedback: Binary protocol | Tarantool

[TarantoolBot]

<…> | | |
| |0x00: IPROTO_REQUEST_TYPE| | 0x01: IPROTO_SYNC | 0x05: IPROTO_SCHEMA_VERSION |
<…>

https://www.tarantool.io/en/doc/2.3/dev_guide/internals/box_protocol/#box-protocol-join

Тут и везде в текстовых схемах одна и та же ошибка.
Вместо "0x00: IPROTO_REQUEST_TYPE" дожно быть "0x00: REQUEST_TYPE" (как было в доке 2.2)
Дело в том, что IPROTO_REQUEST_TYPE == 0x00, и вместо пары Ключ : Значение в доке написано Ключ : Ключ.
Однако (как и написано ниже) IPROTO_REQUEST_TYPE == 0x00.
В строке же 0x00: IPROTO_REQUEST_TYPE
Так вот 0x00: IPROTO_REQUEST_TYPE - это, получается Ключ : Ключ.

[pgulutzan]

We explain near the start: "And words that start with IPROTO_ mean: a Tarantool constant which is either defined or mentioned in the iproto_constants.h file <https://github.com/tarantool/tarantool/blob/master/src/box/iproto_constants.h>_."
The Tarantool source uses it, for example in xrow.c one can see "d = mp_encode_uint(d, IPROTO_REQUEST_TYPE);" in the function for encoding the header.

[alyapunov]

In iproto header the constant IPROTO_REQUEST_TYPE must be followed by a value of request type, for example IPROTO_SELECT or IPROTO_REPLACE. But now in the manual we see that a constant 0x00 if followed by constant IPROTO_REQUEST_TYPE, which is zero as iproto_constants.h states. That's misleading.
Some time ago we had:

|  0x00   | REQUEST_TYPE |
| MP_UINT |   MP_UINT    |

What was meant (sorry if it's confusing either):

|  0x00   | <request type> |
| MP_UINT |    MP_UINT     |

But now we have:

|  0x00   | IPROTO_REQUEST_TYPE |
| MP_UINT |       MP_UINT       |

This is wrong.