Skip to content

[2pt] VShard: deprecate config option 'collect_bucket_garbage_interval' #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
Tracked by #2640
TarantoolBot opened this issue Mar 28, 2021 · 1 comment · Fixed by #4045
Closed
2 tasks
Tracked by #2640

[2pt] VShard: deprecate config option 'collect_bucket_garbage_interval' #2013

TarantoolBot opened this issue Mar 28, 2021 · 1 comment · Fixed by #4045
Assignees
Labels
deprecation [nature] Deprecated functionality ecosystem [area] Task relates to Tarantool's ecosystem (connector, module, other non-server functionality) reference [location] Tarantool manual, Reference part vshard [area] Related to vshard module

Comments

@TarantoolBot
Copy link
Collaborator

TarantoolBot commented Mar 28, 2021

VShard: deprecate config option 'collect_bucket_garbage_interval'

Product: Tarantool, vshard (external module)
Since: 0.1.17 (vshard version; vshard is compatible with Tarantool versions >= 1.9)
Audience/target: developers; Tarantool implementation teams
Root document: https://www.tarantool.io/en/doc/latest/reference/reference_rock/vshard/vshard_ref/#cfg-basic-collect-bucket-garbage-interval
SME: @Gerold103
Peer reviewer: @

Details

It was used to specify the interval between bucket garbage
collection steps. It was needed because garbage collection in
vshard was proactive. It didn't react to newly appeared garbage
buckets immediately.

Since now (0.1.17) garbage collection became reactive. It starts
working with garbage buckets immediately as they appear. And
sleeps rest of the time. The option is not used now and does not
affect behaviour of anything.

I suppose it can be deleted from the documentation. Or left with
a big label 'deprecated' + the explanation above.

An attempt to use the option does not cause an error, but logs a
warning.

Definition of done

  • Mark the collect_bucket_garbage_interval of vshard as depricated with the explanation from Details above. Make sense to also mention the vshard version.
  • Describe also log warning
@Onvember Onvember added the deprecation [nature] Deprecated functionality label Mar 29, 2021
@veod32 veod32 added ecosystem [area] Task relates to Tarantool's ecosystem (connector, module, other non-server functionality) vshard [area] Related to vshard module reference [location] Tarantool manual, Reference part labels Apr 28, 2021
@veod32 veod32 changed the title VShard: deprecate cfg option 'collect_bucket_garbage_interval' [0pt] VShard: deprecate cfg option 'collect_bucket_garbage_interval' Apr 28, 2021
@veod32 veod32 changed the title [0pt] VShard: deprecate cfg option 'collect_bucket_garbage_interval' [0pt] VShard: deprecate config option 'collect_bucket_garbage_interval' Apr 28, 2021
@veod32 veod32 changed the title [0pt] VShard: deprecate config option 'collect_bucket_garbage_interval' [2pt] VShard: deprecate config option 'collect_bucket_garbage_interval' Apr 28, 2021
@veod32 veod32 removed this from the Estimate [@veod32] milestone Apr 28, 2021
@veod32 veod32 added this to the vshard doc issues milestone Aug 27, 2021
@patiencedaur patiencedaur mentioned this issue Feb 1, 2022
21 tasks
@patiencedaur patiencedaur removed this from the vshard milestone Feb 1, 2022
@veod32 veod32 removed the 2sp label May 30, 2023
@andreyaksenov andreyaksenov self-assigned this Feb 15, 2024
@andreyaksenov andreyaksenov linked a pull request Feb 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation [nature] Deprecated functionality ecosystem [area] Task relates to Tarantool's ecosystem (connector, module, other non-server functionality) reference [location] Tarantool manual, Reference part vshard [area] Related to vshard module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants