Skip to content

Sharding reference #4045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Sharding reference #4045

merged 3 commits into from
Feb 21, 2024

Conversation

andreyaksenov
Copy link
Contributor

@andreyaksenov andreyaksenov commented Feb 15, 2024

Copy link
Contributor

@Serpentian Serpentian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the current version, but AFAICS it's still WIP. I'll take another look, when rebalancer_mode is added. Though, I'm not quite sure, we should add connection_outdate_delay as it was undocumented for 6 years.

Just an idea:

.. note::
The option only has an effect if the :ref:`audit_log.to <configuration_reference_audit_to>` is set to ``syslog``
or ``pipe``.

For some options we specify, when it works. Don't we want to say, whether the option applies to storage or router in notes?

@andreyaksenov
Copy link
Contributor Author

andreyaksenov commented Feb 20, 2024

Just an idea:

.. note::
The option only has an effect if the :ref:`audit_log.to <configuration_reference_audit_to>` is set to ``syslog``
or ``pipe``.

For some options we specify, when it works. Don't we want to say, whether the option applies to storage or router in notes?

Good point. Where applicable, I added links to corresponding sections in the topics related to vshard concepts and architecture (such as Rebalancing, Replica weights, and so on). Looks that this should be enough for now. When missing options are implemented in a new config (v3.1, I guess), I plan to rework the whole docs related to sharding and make one more round on updating this reference to make it more consistent.

@andreyaksenov andreyaksenov requested a review from xuniq February 20, 2024 15:22
sharding
--------

The ``sharding`` section defines configuration parameters related to sharding.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@andreyaksenov andreyaksenov Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a link to https://docs.d.tarantool.io/en/doc/sharding-reference/book/admin/vshard_admin/ - I think, this will be the main topic related to sharding configuration when v3.1 is released.

@andreyaksenov andreyaksenov force-pushed the sharding-reference branch 2 times, most recently from f97927f to 91046f9 Compare February 21, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants