Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2pt] feedback: API reference | Unclear wording #2090

Closed
Tracked by #2640
TarantoolBot opened this issue Apr 21, 2021 · 0 comments
Closed
Tracked by #2640

[2pt] feedback: API reference | Unclear wording #2090

TarantoolBot opened this issue Apr 21, 2021 · 0 comments
Assignees
@p7nov
Labels
add details [nature] More details needed, some info missing. Documentation is incomplete. vshard [area] Related to vshard module

Comments

@TarantoolBot
Copy link
Collaborator

TarantoolBot commented Apr 21, 2021 •
edited by art-dr
Loading

Details

<…>s arguments
options –
timeout – a request timeout, in seconds.

|If the router cannot identify a
shard with the specified bucket_id, the operation will be repeated until the
timeout is reached.|

other net.box options, such as is_async,
buffer, on_push are al<…>

It is not clear from context, which exactly operation will be repeated

root document: https://www.tarantool.io/en/doc/latest/reference/reference_rock/vshard/vshard_api/#router-api-call
SME: @ Gerold103
@Onvember Onvember added the add details [nature] More details needed, some info missing. Documentation is incomplete. label Apr 27, 2021
@Onvember Onvember added this to the Doc issues estimate aggregation [@onvember] milestone Apr 27, 2021
@art-dr art-dr changed the title feedback: API reference | Tarantool [2pt] feedback: API reference | Tarantool Apr 28, 2021
@art-dr art-dr added ecosystem [area] Task relates to Tarantool's ecosystem (connector, module, other non-server functionality) vshard [area] Related to vshard module and removed ecosystem [area] Task relates to Tarantool's ecosystem (connector, module, other non-server functionality) labels Apr 28, 2021
@veod32 veod32 modified the milestones: Estimate [@onvember], vshard doc issues Aug 27, 2021
@patiencedaur patiencedaur mentioned this issue Feb 1, 2022
Open
21 tasks
@patiencedaur patiencedaur removed this from the vshard milestone Feb 1, 2022
@patiencedaur patiencedaur changed the title [2pt] feedback: API reference | Tarantool [2pt] feedback: API reference | Unclear wording Feb 15, 2022
@veod32 veod32 removed the 2sp label May 30, 2023
@p7nov p7nov self-assigned this Jul 10, 2023
@p7nov p7nov mentioned this issue Jul 10, 2023
Merged
p7nov added a commit that referenced this issue Jul 10, 2023
@p7nov
Feedback fixes (#3565)
0664102 
Fixes #3260, #3247, #2535, #2441, #2210, #2090, #1787
@p7nov p7nov closed this as completed Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p7nov p7nov

Labels
add details [nature] More details needed, some info missing. Documentation is incomplete. vshard [area] Related to vshard module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@art-dr @Onvember @TarantoolBot @patiencedaur @p7nov @veod32