Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback: Streams and interactive transactions | Example error #2503

Closed
4 tasks done
Tracked by #2603 ...
TarantoolBot opened this issue Dec 20, 2021 · 0 comments · Fixed by #2735
Closed
4 tasks done
Tracked by #2603 ...

feedback: Streams and interactive transactions | Example error #2503

TarantoolBot opened this issue Dec 20, 2021 · 0 comments · Fixed by #2735
Assignees
Labels
add details [nature] More details needed, some info missing. Documentation is incomplete. example Problem with a code example. factual error Factual error in functionality description server [area] Task relates to Tarantool's server (core) functionality

Comments

@TarantoolBot
Copy link
Collaborator

TarantoolBot commented Dec 20, 2021

Fix an error in the example, make a small correction to the article

Product: Tarantool
Root document: https://www.tarantool.io/en/doc/latest/book/box/stream/
SME: @ EvgenyMekhanik

Details

  • space:replace({1}) -> stream_space:replace({1}).
  • The Empty select comment is about conn_space:select({}), please make it obvious.
  • Specify in the article that memtx_use_mvcc_engine must be defined as true on the server.
  • Add @ EvgenyMekhanik as a reviewer.

<…>ream = conn:new_stream()
local stream_space = stream.space.test
**|
-- Begin transaction over an iproto stream:
stream:begin()
space:replace({1})

-- Empty select, the transaction was not committed.
-- You can't see it from the requests that do not belong to the
-- transaction.

-- Select returns the previously inserted tuple,
-- because this select belongs to the transaction:
conn_space:select{}
stream_space:select({})

-- Commit transaction:
stream:commit()

-- Now this select also returns the tuple, because the transaction has been committed:
conn_space:select{}|**

                <…>

https://www.tarantool.io/en/doc/latest/book/box/stream/

там надо space:replace({1}) заменить на stream_space:replace({1}), еще комментарий Empty select относится к conn_space:select({})
Можно еще указать, что memtx_use_mvcc_engine на сервере должен быть true

@patiencedaur patiencedaur changed the title feedback: Streams and interactive transactions | Tarantool [2pt] feedback: Streams and interactive transactions | Example error Dec 20, 2021
@patiencedaur patiencedaur changed the title [2pt] feedback: Streams and interactive transactions | Example error [1pt] feedback: Streams and interactive transactions | Example error Dec 20, 2021
@patiencedaur patiencedaur added server [area] Task relates to Tarantool's server (core) functionality factual error Factual error in functionality description add details [nature] More details needed, some info missing. Documentation is incomplete. labels Dec 20, 2021
@art-dr art-dr changed the title [1pt] feedback: Streams and interactive transactions | Example error feedback: Streams and interactive transactions | Example error Jan 26, 2022
@patiencedaur patiencedaur added the example Problem with a code example. label Feb 28, 2022
patiencedaur added a commit that referenced this issue Mar 3, 2022
@patiencedaur patiencedaur self-assigned this Mar 4, 2022
patiencedaur added a commit that referenced this issue Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add details [nature] More details needed, some info missing. Documentation is incomplete. example Problem with a code example. factual error Factual error in functionality description server [area] Task relates to Tarantool's server (core) functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants