-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2pt] Add comparison table of Go connectors #2484
Conversation
0bdea47
to
b4b8db7
Compare
b4b8db7
to
aefcba3
Compare
aefcba3
to
bcd3a43
Compare
bcd3a43
to
dc48ab6
Compare
Also in last force-push I removed "eval supported" in SQL as discussed |
dc48ab6
to
988f104
Compare
988f104
to
534753e
Compare
So, @Totktonada , is this PR LGTM to send to Doc team for a review? |
534753e
to
c329183
Compare
c329183
to
f0d4c99
Compare
f0d4c99
to
a0ad808
Compare
4dc9eeb
to
ea14306
Compare
I'm ok, @Totktonada ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I left several optional comments.
So it seems like after last commit we don't have any objections and it's ready to merge |
I'll merge this PR and then create a new one where I'll move the table to the "Connectors" chapter, as we've already done with Python connectors (https://www.tarantool.io/en/doc/latest/book/connectors/). It is the safest way not to lose Crowdin translations. |
What's batching in that comparison table btw? |
When we provide an API to collect several requests (usually DML) into a batch and send them at once. It may be necessary for a synchronous connector and has not much sense for an asynchronous one. We removed it from this table, because all those connectors are asynchronous. |
OK, thanks! One feature of viciious/go-tarantool that may come handy for some people is that is also provides instrumentation for reading snapshot and xlog files via snapio module: https://github.com/viciious/go-tarantool/tree/master/snapio Not sure whether you want it in the comparison table or not but I thought it was worth mentioning anyway |
Nice! I filed #2637 to don't forget about it. |
Oh and it also supports connecting to Tarantool instance as a replication slave and also implements unpacking of query structs should you want to implement your own Iproto proxy. Guess that's worth adding to comparison table as well. |
It is in the table (written as 'Can mimic a Tarantool instance (also as replica)').
Looks worthful to mention, thanks! Aren't you mind to open a pull request aginst the |
@viciious If you do open a PR as @Totktonada suggested above, please mention or assign me and @arctic-dreamer. Thanks! |
Filed #2645 to don't miss it. |
Compare features of our own tarantool/go-tarantool connector with two open-source connectors: viciious/go-tarantool and FZambia/tarantool.