Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2pt] Add comparison table of Go connectors #2484

Merged
merged 8 commits into from
Jan 26, 2022

Conversation

DifferentialOrange
Copy link
Member

Compare features of our own tarantool/go-tarantool connector with two open-source connectors: viciious/go-tarantool and FZambia/tarantool.

@github-actions github-actions bot temporarily deployed to translation-go-comparison December 8, 2021 07:59 Inactive
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/go-comparison branch 2 times, most recently from 0bdea47 to b4b8db7 Compare December 8, 2021 08:27
@github-actions github-actions bot temporarily deployed to translation-go-comparison December 8, 2021 08:28 Inactive
@github-actions github-actions bot temporarily deployed to translation-go-comparison December 8, 2021 08:28 Inactive
@github-actions github-actions bot temporarily deployed to translation-go-comparison December 8, 2021 15:28 Inactive
@github-actions github-actions bot temporarily deployed to translation-go-comparison December 20, 2021 15:14 Inactive
@DifferentialOrange
Copy link
Member Author

Btw, I'm lucky that there are only three connectors and there are no issues with 5th column like in Python comparison table.
image

@DifferentialOrange
Copy link
Member Author

DifferentialOrange commented Dec 20, 2021

Also in last force-push I removed "eval supported" in SQL as discussed

@DifferentialOrange
Copy link
Member Author

@github-actions github-actions bot temporarily deployed to translation-go-comparison December 24, 2021 08:28 Inactive
@github-actions github-actions bot temporarily deployed to translation-go-comparison December 24, 2021 08:32 Inactive
@DifferentialOrange
Copy link
Member Author

So, @Totktonada , is this PR LGTM to send to Doc team for a review?

@github-actions github-actions bot temporarily deployed to translation-go-comparison December 27, 2021 06:57 Inactive
@github-actions github-actions bot temporarily deployed to translation-go-comparison December 27, 2021 09:20 Inactive
@patiencedaur patiencedaur force-pushed the DifferentialOrange/go-comparison branch from 4dc9eeb to ea14306 Compare January 25, 2022 07:11
@github-actions github-actions bot temporarily deployed to translation-go-comparison January 25, 2022 07:13 Inactive
@github-actions github-actions bot temporarily deployed to translation-go-comparison January 25, 2022 07:17 Inactive
@DifferentialOrange
Copy link
Member Author

I'm ok, @Totktonada ?

@Totktonada Totktonada self-requested a review January 25, 2022 11:18
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I left several optional comments.

@github-actions github-actions bot temporarily deployed to translation-go-comparison January 26, 2022 05:50 Inactive
@github-actions github-actions bot temporarily deployed to translation-go-comparison January 26, 2022 06:04 Inactive
@DifferentialOrange
Copy link
Member Author

So it seems like after last commit we don't have any objections and it's ready to merge

@patiencedaur patiencedaur removed the request for review from NickVolynkin January 26, 2022 10:15
@art-dr
Copy link
Contributor

art-dr commented Jan 26, 2022

I'll merge this PR and then create a new one where I'll move the table to the "Connectors" chapter, as we've already done with Python connectors (https://www.tarantool.io/en/doc/latest/book/connectors/). It is the safest way not to lose Crowdin translations.

@art-dr art-dr merged commit 00e3671 into latest Jan 26, 2022
@art-dr art-dr deleted the DifferentialOrange/go-comparison branch January 26, 2022 10:25
@viciious
Copy link

viciious commented Jan 27, 2022

What's batching in that comparison table btw?

@Totktonada
Copy link
Member

When we provide an API to collect several requests (usually DML) into a batch and send them at once. It may be necessary for a synchronous connector and has not much sense for an asynchronous one.

We removed it from this table, because all those connectors are asynchronous.

@viciious
Copy link

OK, thanks!

One feature of viciious/go-tarantool that may come handy for some people is that is also provides instrumentation for reading snapshot and xlog files via snapio module: https://github.com/viciious/go-tarantool/tree/master/snapio

Not sure whether you want it in the comparison table or not but I thought it was worth mentioning anyway

@Totktonada
Copy link
Member

Nice! I filed #2637 to don't forget about it.

@viciious
Copy link

viciious commented Jan 27, 2022

Oh and it also supports connecting to Tarantool instance as a replication slave and also implements unpacking of query structs should you want to implement your own Iproto proxy. Guess that's worth adding to comparison table as well.

@Totktonada
Copy link
Member

supports connecting to Tarantool instance as a replication slave

It is in the table (written as 'Can mimic a Tarantool instance (also as replica)').

implements unpacking of query structs should you want to implement your own Iproto proxy

Looks worthful to mention, thanks!

Aren't you mind to open a pull request aginst the doc/book/connectors/__go.rst file in this repository? So you can give your wording for your connector.

@patiencedaur
Copy link
Contributor

@viciious If you do open a PR as @Totktonada suggested above, please mention or assign me and @arctic-dreamer. Thanks!

@Totktonada
Copy link
Member

Filed #2645 to don't miss it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants