Skip to content

Add tt CLI docs #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jul 8, 2022
Merged

Add tt CLI docs #2973

merged 26 commits into from
Jul 8, 2022

Conversation

p7nov
Copy link
Contributor

@p7nov p7nov commented Jun 22, 2022

Resolves #2554 #2976 #2555 #2566

@p7nov p7nov marked this pull request as draft June 22, 2022 12:08
@p7nov p7nov added the do not merge Not ready to be merged label Jun 22, 2022
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli June 22, 2022 12:09 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli June 23, 2022 08:28 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli June 23, 2022 10:57 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli June 24, 2022 07:16 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli June 24, 2022 07:49 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli June 28, 2022 09:00 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli June 28, 2022 09:03 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli June 28, 2022 09:25 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli June 28, 2022 11:48 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli June 28, 2022 12:19 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli June 28, 2022 12:39 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli June 28, 2022 12:53 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli June 28, 2022 13:08 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli June 29, 2022 04:24 Inactive
@p7nov p7nov requested a review from LeonidVas July 6, 2022 06:06
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli July 6, 2022 06:06 Inactive
Copy link

@LeonidVas LeonidVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for the patchset.
I didn't check the commit message, just the changes in the files, and them seems good.

``-i``
- Force the use of an internal module even if there is an external module with the same name.
.. // TODO: add link to external modules doc page when it's ready
* - ``--local=DIRECTORY``

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I don't know if that's normal or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed the layout

@p7nov p7nov removed the do not merge Not ready to be merged label Jul 8, 2022
@p7nov p7nov requested a review from patiencedaur July 8, 2022 03:49
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli July 8, 2022 04:00 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli July 8, 2022 05:41 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli July 8, 2022 05:42 Inactive
Copy link
Contributor

@patiencedaur patiencedaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Here are some suggestions.


``tt`` is going to become a single tool for working with Tarantool
from the command line and replace :doc:`tarantoolctl </reference/tarantoolctl>` and
:doc:`Cartridge CLI </book/cartridge/cartridge_cli/index>` in the future.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unsafe to leave relative remarks about time in the docs, like "now" and "in the future". What ir the user reads it in the said future, and the doc hasn't been updated yet? We can't catch all the "todays" and "nows" across the docs.

Please rephrase the sentence. The first option that comes to my mind is something like "It is envisioned as a tool that can potentially replace..." Feel free to use this or another option.

I'll add a style guideline discouraging the use of relative time adverbs. Here's a related issue: #2202


.. warning::

``tt`` is currently in the early development stage. It includes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Currently" is also relative. I would suggest using "as of [date]" instead or mentioning the release it was introduced in.

Co-authored-by: Dia Patience Daur <patiencedaur@gmail.com>
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli July 8, 2022 07:45 Inactive
Co-authored-by: Dia Patience Daur <patiencedaur@gmail.com>
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli July 8, 2022 08:10 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli July 8, 2022 08:30 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli July 8, 2022 08:41 Inactive
@p7nov p7nov requested a review from patiencedaur July 8, 2022 08:52
@github-actions github-actions bot temporarily deployed to branch-gh-2553-tt-cli July 8, 2022 08:53 Inactive
Copy link
Contributor

@patiencedaur patiencedaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with 1 minor question.


.. code-block:: bash

. <(tt completion bash)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why parentheses?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2pt] Intro to TT CLI
3 participants