Skip to content

Add tt coredump #3139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2022
Merged

Add tt coredump #3139

merged 3 commits into from
Sep 12, 2022

Conversation

p7nov
Copy link
Contributor

@p7nov p7nov commented Sep 9, 2022

Resolves #3000

@p7nov p7nov requested a review from better0fdead September 9, 2022 06:04
better0fdead
better0fdead approved these changes Sep 9, 2022
View reviewed changes
Copy link

@better0fdead better0fdead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p7nov p7nov requested a review from patiencedaur September 9, 2022 10:26
patiencedaur
patiencedaur approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@patiencedaur patiencedaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Food for thought: How necessary is it to alphabetize the command list?

@p7nov
Copy link
Contributor Author

p7nov commented Sep 12, 2022

LGTM. Food for thought: How necessary is it to alphabetize the command list?

Yeah, will do when adding the next command.

@p7nov p7nov merged commit ef75e7c into latest Sep 12, 2022
@p7nov p7nov deleted the tt-coredump branch September 12, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patiencedaur patiencedaur patiencedaur approved these changes

@better0fdead better0fdead better0fdead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tt coredump
3 participants
@p7nov @patiencedaur @better0fdead