Skip to content

Update the example in module net.box #3186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 18, 2022
Merged

Update the example in module net.box #3186

merged 8 commits into from
Oct 18, 2022

Conversation

xuniq
Copy link
Contributor

@xuniq xuniq commented Oct 11, 2022

@xuniq xuniq requested a review from locker October 12, 2022 06:22
@xuniq xuniq marked this pull request as draft October 13, 2022 19:33
@xuniq xuniq force-pushed the gh-2271-netbox-example branch from 9bc6ea5 to a65286e Compare October 13, 2022 19:35
@xuniq xuniq marked this pull request as ready for review October 17, 2022 10:25
@xuniq xuniq requested a review from p7nov October 17, 2022 10:31
Copy link
Contributor

@p7nov p7nov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Some comments from my side.

@xuniq
Copy link
Contributor Author

xuniq commented Oct 18, 2022

In the old example, the net.box methods were wrapped in the example() function. That function looked redundant. So, the example has been rewritten and moved to the how-to chapter as an introductory net.box tutorial:
https://docs.d.tarantool.io/en/doc/gh-2271-netbox-example/how-to/getting_started_net_box/

@xuniq xuniq requested a review from locker October 18, 2022 07:44
@xuniq xuniq merged commit 948adeb into latest Oct 18, 2022
@xuniq xuniq deleted the gh-2271-netbox-example branch October 18, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3pt] feedback: Module net.box | Poor example
3 participants