-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New URI functions #3587
New URI functions #3587
Conversation
f87bb88
to
f801171
Compare
a6e4e73
to
ece505e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Andrey, thanks!
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -116,7 +116,8 @@ In certain circumstances, a Unix domain socket may be used | |||
where a URI is expected, for example, "unix/:/tmp/unix_domain_socket.sock" or | |||
simply "/tmp/unix_domain_socket.sock". | |||
|
|||
A method for parsing URIs is illustrated in :ref:`Module uri <uri-parse>`. | |||
The :ref:`uri <uri-parse>` module provides functions that convert URI strings into their |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe link to the module page, not a specific function?
doc/reference/reference_lua/uri.rst
Outdated
|
||
[scheme:]scheme-specific-part[#fragment] | ||
The URI module provides functions that convert URI strings into their |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe leave a link to the resource where URI is defined and explained?
doc/reference/reference_lua/uri.rst
Outdated
|
||
* Pass custom encoding options using the :ref:`uri_encoding_opts <uri_encoding_opts>` object. | ||
|
||
:param string: a string to be encoded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:param string: a string to be encoded | |
:param string: a string to encode |
doc/reference/reference_lua/uri.rst
Outdated
|
||
* Pass custom encoding options using the :ref:`uri_encoding_opts <uri_encoding_opts>` object. | ||
|
||
:param string: a string to be decoded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:param string: a string to be decoded | |
:param string: a string to decode |
doc/reference/reference_lua/uri.rst
Outdated
The ``uri_components`` object is used in the following functions: | ||
|
||
* The :ref:`uri.parse() <uri-parse>` function returns the ``uri_components`` object. | ||
* The :ref:`uri.format() <uri-format>` function accepts the ``uri_components`` object as the parameter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an as argument?
ece505e
to
56f8f72
Compare
escape
,unescape
, encoding options): Module uri