Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TCM overview #3848

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Add TCM overview #3848

merged 2 commits into from
Nov 15, 2023

Conversation

p7nov
Copy link
Contributor

@p7nov p7nov commented Nov 13, 2023

Resolves #3601

  • Add new section Tarantool Cluster Manager in Tooling
  • Write a general TCM overview

Deployment: https://docs.d.tarantool.io/en/doc/gh-3601-tcm-section/reference/tooling/tcm/

Important notes:

  1. The page location is temporary. The whole TCM section will be moved in scope of 3.0 docs restructurization ([Epic] Doc restructurization #3817) to be more discoverable and fit into the new structure.
  2. The content will change too. I plan to add more feature descriptions to the overview page when writing specific pages inside the TCM section.

@p7nov p7nov force-pushed the gh-3601-tcm-section branch 3 times, most recently from 1dd98c2 to 178d485 Compare November 14, 2023 09:44
@filonenko-mikhail
Copy link

lgtm

Copy link
Contributor

@andreyaksenov andreyaksenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of suggestions to think about

distribution package. It is shipped as an executable that is ready to run on Linux
and macOS platforms.

|tcm| works only with Tarantool EE clusters that are configured through `etcd <https://etcd.io/>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configured through etcd sounds like etcd is a tool for configuring a Tarantool, not to store a configuration (smth like configured through a web interface). Maybe, ... that use etcd as a configuration storage would work better.


|tcm| works only with Tarantool EE clusters that are configured through `etcd <https://etcd.io/>`_.
When you create or edit a cluster's configuration in |tcm|, it sends the saved
configuration to etcd. This ensures consistent and reliable configuration storage.
Copy link
Contributor

@andreyaksenov andreyaksenov Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, replace sends with publishes for terminology consistency with tt: ... it publishes the saved configuration to etcd.. Looks like send work better for networking things, for example, sending a network packet.

|tcm| works only with Tarantool EE clusters that are configured through `etcd <https://etcd.io/>`_.
When you create or edit a cluster's configuration in |tcm|, it sends the saved
configuration to etcd. This ensures consistent and reliable configuration storage.
Learn more about :ref:`storing configuration in etcd <configuration_etcd>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this sentence and update the etcd link above to our internal doc. Looks like the explicit learn more link to a technical tutorial might be unnecessary for a high-level overview.

Learn more about :ref:`storing configuration in etcd <configuration_etcd>`.

A single |tcm| installation can manage multiple Tarantool EE clusters.
A convenient switch in the web UI lets you select the desired cluster in one click.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph sounds a bit too marketingish to me :) At the beginning, we already said about managing EE clusters and this might be enough IMO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, rephrased. AFAIR our PM wanted to highlight that one TCM can manage multiple clusters, so I'm leaving it, although in a more technical wording.

@p7nov p7nov merged commit b7f26a6 into 3.0 Nov 15, 2023
1 check passed
@p7nov p7nov deleted the gh-3601-tcm-section branch November 15, 2023 05:42
andreyaksenov pushed a commit that referenced this pull request Nov 21, 2023
andreyaksenov pushed a commit that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants