3.0 new iproto format #3947
Merged
3.0 new iproto format #3947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreyaksenov
force-pushed
the
3.0-new-iproto-format
branch
2 times, most recently
from
0d83fa9 to
40176f0
Compare
andreyaksenov
force-pushed
the
3.0-new-iproto-format
branch
from
40176f0 to
fd5d283
Compare
andreyaksenov
force-pushed
the
3.0-new-iproto-format
branch
from
6771dde to
9a747c1
Compare
andreyaksenov
force-pushed
the
3.0-new-iproto-format
branch
3 times, most recently
from
3dccf04 to
10b462b
Compare
psergee
reviewed
Dec 21, 2023
| } | ||
|
|
||
| dependencies = { | ||
| 'vshard == 0.1.25' |
There was a problem hiding this comment.
As I can see, the latest vshard version is 0.1.24. Suppose, tt rocks make will not work with this rockspec until 0.1.25 is out.
There was a problem hiding this comment.
@Totktonada Am I correct that the latest config should work with vshard 0.1.25 only? If the new version will be released at the same time as 3.0.0, keeping the new vshard option in the doc sample should be OK. Otherwise, don't know what decision is the best.
There was a problem hiding this comment.
There was a problem hiding this comment.
Vshard was released today. It was carefully planned :)
andreyaksenov
force-pushed
the
3.0-new-iproto-format
branch
3 times, most recently
from
e18b248 to
25a635b
Compare
andreyaksenov
force-pushed
the
3.0-new-iproto-format
branch
from
25a635b to
59fb2fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected topics:
iprotosection):