Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharding config #4155

Merged
merged 3 commits into from
May 20, 2024
Merged

Sharding config #4155

merged 3 commits into from
May 20, 2024

Conversation

andreyaksenov
Copy link
Contributor

@andreyaksenov andreyaksenov commented Apr 12, 2024

Updated topics:

I don't quite like the result. IMO, it is necessary to merge these topics in the future and show all the information in one page. For now, there is much legacy content, duplicated info, and unnecessary internal details. Also, I don't understand why Sharding with vshard lives in the Admin section.

Configuration reference (3.1 options):

Getting started:

  • Wrapped data definition into box.once(): Adding storage code. This code snippet is also reused in the updated Sharding with vshard topic.

Reference:

  • Added a link to Adding storage code in the box.once() description.

@andreyaksenov andreyaksenov linked an issue Apr 12, 2024 that may be closed by this pull request
7 tasks
@andreyaksenov andreyaksenov force-pushed the sharding-admin branch 9 times, most recently from c22545c to 47f75f2 Compare April 15, 2024 14:42
@andreyaksenov andreyaksenov force-pushed the sharding-admin branch 4 times, most recently from ab33c1e to 0bc91ac Compare April 16, 2024 07:35
@andreyaksenov andreyaksenov linked an issue Apr 16, 2024 that may be closed by this pull request
@andreyaksenov andreyaksenov force-pushed the sharding-admin branch 2 times, most recently from 872bf92 to 8d267e2 Compare April 17, 2024 09:04
@andreyaksenov andreyaksenov force-pushed the sharding-admin branch 9 times, most recently from 7548054 to 5526160 Compare May 14, 2024 06:51
@andreyaksenov andreyaksenov marked this pull request as ready for review May 14, 2024 08:46
@andreyaksenov andreyaksenov requested a review from xuniq May 16, 2024 06:52
# ...

Note that the ``rebalancer`` role is optional.
If it is not specified, a rebalancer is selected automatically from master instances of replica sets.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If it is not specified, a rebalancer is selected automatically from master instances of replica sets.
If it is not specified, a rebalancer is selected automatically from the master instances of replica sets.

information about the new location of the bucket.
When a new shard is added, a configuration should be reloaded on each instance to migrate buckets to a new shard:

* If a :ref:`centralized configuration storages <configuration_etcd>` is used, Tarantool reloads a changed configuration automatically.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* If a :ref:`centralized configuration storages <configuration_etcd>` is used, Tarantool reloads a changed configuration automatically.
* If a :ref:`centralized configuration storage <configuration_etcd>` is used, Tarantool reloads a changed configuration automatically.

@andreyaksenov andreyaksenov merged commit d0a40d4 into latest May 20, 2024
1 check failed
@andreyaksenov andreyaksenov deleted the sharding-admin branch May 20, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants