-
Notifications
You must be signed in to change notification settings - Fork 43
Add TCM LDAP authentication #4468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Some minor comments/suggestions from me:
|
||
Enter the LDAP server connection parameters: | ||
|
||
* **Endpoints**. URLs of the LDAP server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be convenient to have an example here. So, a user can understand that 127.0.0.1:5056
is enough and the `ldap://`` schema is not required.
* **Endpoints**. URLs of the LDAP server. | ||
* **Request timeout**. The timeout for |tcm| requests to the LDAP server, in seconds. | ||
* **Enabled TLS**. If the server uses LDAPS, turn this toggle on and specify | ||
TLS connection parameters, such as a certificate and a key file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, add the Click **Next** ...
sentence after the list?
shown above, it substitutes ``{0}`` with the username part of the email address (before ``@``) | ||
entered into the login form. For example, the username ``user1@tarantool.io`` | ||
forms the following DN for bind request: ``cn=user1,cn=users,dc=tarantool,dc=io``. | ||
- **Template query**. A template for querying the LDAP server for the DN. This |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea: mark such fields with (optional)
explicitly (like we do in API docs)
|
||
.. _tcm_ldap_auth_config_disable: | ||
|
||
Disabling LDAP configurations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
Disabling LDAP configurations | |
Turning of LDAP configurations |
Co-authored-by: Andrey Aksenov <38073144+andreyaksenov@users.noreply.github.com>
Resolves #3635
Deployment: https://docs.d.tarantool.io/en/doc/gh-3635-tcm-ldap/tooling/tcm/tcm_access_control/tcm_ldap_auth/