Skip to content

Add TCM LDAP authentication #4468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 28, 2024
Merged

Add TCM LDAP authentication #4468

merged 9 commits into from
Aug 28, 2024

Conversation

p7nov
Copy link
Contributor

@p7nov p7nov commented Aug 26, 2024

@p7nov p7nov requested a review from vaintrub August 27, 2024 10:58
@p7nov p7nov requested a review from andreyaksenov August 27, 2024 14:25
Copy link
Contributor

@andreyaksenov andreyaksenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some minor comments/suggestions from me:


Enter the LDAP server connection parameters:

* **Endpoints**. URLs of the LDAP server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be convenient to have an example here. So, a user can understand that 127.0.0.1:5056 is enough and the `ldap://`` schema is not required.

* **Endpoints**. URLs of the LDAP server.
* **Request timeout**. The timeout for |tcm| requests to the LDAP server, in seconds.
* **Enabled TLS**. If the server uses LDAPS, turn this toggle on and specify
TLS connection parameters, such as a certificate and a key file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, add the Click **Next** ... sentence after the list?

shown above, it substitutes ``{0}`` with the username part of the email address (before ``@``)
entered into the login form. For example, the username ``user1@tarantool.io``
forms the following DN for bind request: ``cn=user1,cn=users,dc=tarantool,dc=io``.
- **Template query**. A template for querying the LDAP server for the DN. This
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea: mark such fields with (optional) explicitly (like we do in API docs)


.. _tcm_ldap_auth_config_disable:

Disabling LDAP configurations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
Disabling LDAP configurations
Turning of LDAP configurations

p7nov and others added 4 commits August 28, 2024 15:34
Co-authored-by: Andrey Aksenov <38073144+andreyaksenov@users.noreply.github.com>
@p7nov p7nov merged commit a855e17 into latest Aug 28, 2024
1 check passed
@p7nov p7nov deleted the gh-3635-tcm-ldap branch August 28, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TCM] LDAP
3 participants