Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference for box.stat.memtx().tx #4501

Merged
merged 11 commits into from
Sep 23, 2024
Merged

Add reference for box.stat.memtx().tx #4501

merged 11 commits into from
Sep 23, 2024

Conversation

lenkis
Copy link
Contributor

@lenkis lenkis commented Sep 13, 2024

No description provided.

Copy link

@drewdzzz drewdzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, LGTM!

@lenkis lenkis requested a review from p7nov September 17, 2024 10:49
Copy link
Contributor

@p7nov p7nov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some improvement suggestions and ideas from my side

doc/reference/reference_lua/box_stat.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_stat/memtx.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_stat/memtx.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_stat/memtx.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_stat/memtx.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_stat/memtx.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_stat/memtx.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_stat/memtx.rst Outdated Show resolved Hide resolved
@p7nov
Copy link
Contributor

p7nov commented Sep 17, 2024

There is also box.stat.reset() function. Does it reset new memtx stats?

doc/reference/reference_lua/box_stat/memtx.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_stat/memtx.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@p7nov p7nov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple fixes in suggestions.

doc/reference/reference_lua/box_stat/memtx.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_stat/memtx.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_stat/memtx.rst Outdated Show resolved Hide resolved
@lenkis lenkis merged commit 37b9626 into latest Sep 23, 2024
1 check passed
@lenkis lenkis deleted the lenkis/gh-2801-memtx-tx branch September 23, 2024 11:23
@Totktonada Totktonada restored the lenkis/gh-2801-memtx-tx branch September 23, 2024 11:37
@Totktonada Totktonada deleted the lenkis/gh-2801-memtx-tx branch September 23, 2024 11:37
lenkis added a commit that referenced this pull request Sep 23, 2024
Closes gh-4501 Add reference for box.stat.memtx().tx
lenkis added a commit that referenced this pull request Sep 23, 2024
Closes gh-4501 Add reference for box.stat.memtx().tx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants