Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description for the age and confirm_lag fields in box.info.synchro.queue #4559

Merged
merged 5 commits into from
Oct 18, 2024
Merged

Add description for the age and confirm_lag fields in box.info.synchro.queue #4559

merged 5 commits into from
Oct 18, 2024

Conversation

xuniq
Copy link
Contributor

@xuniq xuniq commented Sep 30, 2024 •
edited
Loading

@xuniq xuniq requested a review from Gerold103 October 2, 2024 07:37
@xuniq xuniq force-pushed the gh-4284-box_info_synchro_queue branch from c2ed069 to 4ca2736 Compare October 7, 2024 08:55
@xuniq xuniq requested review from sergepetrenko and removed request for Gerold103 October 7, 2024 08:56
sergepetrenko
sergepetrenko previously requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@sergepetrenko sergepetrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!
Please find my comments below.

doc/reference/reference_lua/box_info/synchro.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_info/synchro.rst Outdated Show resolved Hide resolved
@xuniq xuniq force-pushed the gh-4284-box_info_synchro_queue branch from 1b0c499 to 1c3372d Compare October 10, 2024 08:39
Gerold103
Gerold103 reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@Gerold103 Gerold103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! I tried to provide an example in one of my comments how to reproduce the non-empty queue in a realistic way.

doc/reference/reference_lua/box_info/synchro.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_info/synchro.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_info/synchro.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_info/synchro.rst Show resolved Hide resolved
@xuniq xuniq force-pushed the gh-4284-box_info_synchro_queue branch from dfbd04b to 149218e Compare October 17, 2024 07:55
@xuniq xuniq requested a review from Gerold103 October 17, 2024 08:11
lenkis
lenkis approved these changes Oct 18, 2024
View reviewed changes
doc/reference/reference_lua/box_info/synchro.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_info/synchro.rst Outdated Show resolved Hide resolved
doc/reference/reference_lua/box_info/synchro.rst Outdated Show resolved Hide resolved
@xuniq @lenkis
Apply suggestions from code review
2a5a077 
Co-authored-by: Elena Shebunyaeva <elena.shebunyaeva@gmail.com>
@xuniq xuniq enabled auto-merge (squash) October 18, 2024 07:48
@veod32 veod32 removed the request for review from sergepetrenko October 18, 2024 08:45
@veod32 veod32 dismissed sergepetrenko’s stale review October 18, 2024 08:48

Done by another reviewer instead

@xuniq xuniq merged commit f0695d1 into latest Oct 18, 2024
1 check passed
@xuniq xuniq deleted the gh-4284-box_info_synchro_queue branch October 18, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenkis lenkis lenkis approved these changes

@Gerold103 Gerold103 Gerold103 approved these changes

@sergepetrenko sergepetrenko sergepetrenko left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feedback: box.info.synchro | Tarantool New age and confirm_lag fields in box.info.synchro.queue
4 participants
@xuniq @Gerold103 @lenkis @sergepetrenko