Fixes in Makefile and expirationd.lua #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running testing by default on running make would be more useful than showing a message about empty target.
ligurio
force-pushed
the
ligurio/fixes
branch
4 times, most recently
from
3a35f09 to
4be9cd0
Compare
olegrok
reviewed
Sep 10, 2021
- move a list of files to remove to a variable - remove tarantool.log too - added a separate `clean` target
See sources in [1] and [2]. 1. tarantool/tarantool#2040 2. https://www.tarantool.io/en/doc/1.6/whats_new/
box.cfg.logger is deprecated option
ligurio
force-pushed
the
ligurio/fixes
branch
from
4be9cd0 to
6dcc96b
Compare
olegrok
approved these changes
Sep 10, 2021
ligurio
force-pushed
the
ligurio/fixes
branch
from
6dcc96b to
eac1e0a
Compare
Totktonada
reviewed
Sep 10, 2021
| @@ -1,3 +1,8 @@ | |||
| CLEANUP_FILES = tarantool.log | |||
| CLEANUP_FILES += *.xlog* | |||
There was a problem hiding this comment.
- A typo (
*.xlog*->*.xlog)? - How about
*.vylog?
There was a problem hiding this comment.
I kept all file masks as is, but moved them to a separate variable. However 1 and 2 are good points. I think we can address it in #76. Vinyl tests are broken and I think it's a reason why *.vylog is not there.
Totktonada
reviewed
Sep 10, 2021
Comment on lines
+15
to
+17
| - [expirationd](https://github.com/tarantool/expirationd/issues/53) always | ||
| expires tuples without using indices but using any condition, without guarantee | ||
| for time expiration. |
There was a problem hiding this comment.
Probably yes. Although proposed table is good enough to make an opinion about these projects.
ArtDu
pushed a commit
to ArtDu/expirationd
that referenced
this pull request
May 10, 2022
Follows up tarantool#71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.