Skip to content

Commit

Permalink
CI: disable Windows runner
Browse files Browse the repository at this point in the history
Disabling of the Windows runner. These tests were flaking.
Because we don't support connector on Windows, I considered
disabling these tests.

Part of #10
  • Loading branch information
DerekBum authored and oleg-jukovec committed Oct 4, 2023
1 parent 5564791 commit 336ca93
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 26 deletions.
7 changes: 0 additions & 7 deletions .github/actions/go-test-setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,6 @@ runs:
shell: bash
run: |
echo 'CGO_ENABLED=1' >> $GITHUB_ENV
- name: Windows setup
shell: bash
if: ${{ runner.os == 'Windows' }}
run: |
pacman -S --noconfirm mingw-w64-x86_64-toolchain mingw-w64-i686-toolchain
echo '/c/msys64/mingw64/bin' >> $GITHUB_PATH
echo 'PATH_386=/c/msys64/mingw32/bin:${{ env.PATH_386 }}' >> $GITHUB_ENV
- name: Linux setup
shell: bash
if: ${{ runner.os == 'Linux' }}
Expand Down
10 changes: 1 addition & 9 deletions .github/workflows/go-test-ubuntu-22.04.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,6 @@ jobs:
run: |
go version
go env
- name: Use msys2 on windows
if: startsWith(matrix.os, 'windows')
shell: bash
# The executable for msys2 is also called bash.cmd
# https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md#shells
# If we prepend its location to the PATH
# subsequent 'shell: bash' steps will use msys2 instead of gitbash
run: echo "C:/msys64/usr/bin" >> $GITHUB_PATH
- name: Run repo-specific setup
uses: ./.github/actions/go-test-setup
if: hashFiles('./.github/actions/go-test-setup') != ''
Expand All @@ -55,7 +47,7 @@ jobs:
export "PATH=${{ env.PATH_386 }}:$PATH"
go test -v ./...
- name: Run tests with race detector
if: startsWith(matrix.os, 'ubuntu') # speed things up. Windows and OSX VMs are slow
if: startsWith(matrix.os, 'ubuntu') # speed things up. OSX VMs is slow
uses: protocol/multiple-go-modules@v1.2
with:
run: go test -v -race ./...
Expand Down
12 changes: 2 additions & 10 deletions .github/workflows/go-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ "ubuntu", "windows", "macos" ]
os: [ "ubuntu", "macos" ]
go: [ "1.18.x", "1.19.x" ]
env:
COVERAGES: ""
Expand All @@ -26,14 +26,6 @@ jobs:
run: |
go version
go env
- name: Use msys2 on windows
if: ${{ matrix.os == 'windows' }}
shell: bash
# The executable for msys2 is also called bash.cmd
# https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md#shells
# If we prepend its location to the PATH
# subsequent 'shell: bash' steps will use msys2 instead of gitbash
run: echo "C:/msys64/usr/bin" >> $GITHUB_PATH
- name: Run repo-specific setup
uses: ./.github/actions/go-test-setup
if: hashFiles('./.github/actions/go-test-setup') != ''
Expand All @@ -54,7 +46,7 @@ jobs:
export "PATH=${{ env.PATH_386 }}:$PATH"
go test -v -shuffle=on ./...
- name: Run tests with race detector
if: ${{ matrix.os == 'ubuntu' }} # speed things up. Windows and OSX VMs are slow
if: ${{ matrix.os == 'ubuntu' }} # speed things up. OSX VMs is slow
uses: protocol/multiple-go-modules@v1.2
with:
run: go test -v -race ./...
Expand Down

0 comments on commit 336ca93

Please sign in to comment.