Skip to content

Clean up excessive test setup #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DifferentialOrange opened this issue Dec 27, 2021 · 0 comments · Fixed by #132
Closed

Clean up excessive test setup #128

DifferentialOrange opened this issue Dec 27, 2021 · 0 comments · Fixed by #132
Assignees
Labels
code health Improve code readability, simplify maintenance and so on

Comments

@DifferentialOrange
Copy link
Member

DifferentialOrange commented Dec 27, 2021

#104 added excessive code in main root config

go-tarantool/config.lua

Lines 64 to 84 in fd68e12

-- Create space with UUID pk if supported
local uuid = require('uuid')
local msgpack = require('msgpack')
local uuid_msgpack_supported = pcall(msgpack.encode, uuid.new())
if uuid_msgpack_supported then
local suuid = box.schema.space.create('testUUID', {
id = 524,
if_not_exists = true,
})
suuid:create_index('primary', {
type = 'tree',
parts = {{ field = 1, type = 'uuid' }},
if_not_exists = true
})
suuid:truncate()
box.schema.user.grant('test', 'read,write', 'space', 'testUUID', { if_not_exists = true })
suuid:insert({ uuid.fromstr("c8f0fa1f-da29-438c-a040-393f1126ad39") })
end

I forgot to clean it up after moving all UUID-related code to the separate folder.

@DifferentialOrange DifferentialOrange added teamE code health Improve code readability, simplify maintenance and so on labels Dec 27, 2021
@DifferentialOrange DifferentialOrange self-assigned this Dec 27, 2021
@DifferentialOrange DifferentialOrange changed the title Clean up excessive code Clean up excessive test setup Dec 27, 2021
DifferentialOrange added a commit that referenced this issue Jan 13, 2022
After moving UUID-related code (including tests) in PR #104
to separate folder, test setup of UUID space was remained in
main folder config.lua by mistake. This patch removes it.

Closes #128
DifferentialOrange added a commit that referenced this issue Jan 13, 2022
After moving UUID-related code (including tests) in PR #104
to separate folder, test setup of UUID space was remained in
main folder config.lua by mistake. This patch removes it.

Closes #128
ligurio pushed a commit that referenced this issue Mar 7, 2022
After moving UUID-related code (including tests) in PR #104
to separate folder, test setup of UUID space was remained in
main folder config.lua by mistake. This patch removes it.

Closes #128
ligurio pushed a commit that referenced this issue Mar 30, 2022
After moving UUID-related code (including tests) in PR #104
to separate folder, test setup of UUID space was remained in
main folder config.lua by mistake. This patch removes it.

Closes #128
ligurio pushed a commit that referenced this issue Apr 7, 2022
After moving UUID-related code (including tests) in PR #104
to separate folder, test setup of UUID space was remained in
main folder config.lua by mistake. This patch removes it.

Closes #128
oleg-jukovec added a commit that referenced this issue Jun 27, 2023
- ExampleConnection_Do demonstrates how to process a result.
- ExampleConnection_Do_failure demonstrates how to process a request
  failure.

Closes #128
oleg-jukovec added a commit that referenced this issue Jun 27, 2023
- ExampleConnection_Do demonstrates how to process a result.
- ExampleConnection_Do_failure demonstrates how to process a request
  failure.

Closes #128
oleg-jukovec added a commit that referenced this issue Jun 28, 2023
- ExampleConnection_Do demonstrates how to process a result.
- ExampleConnection_Do_failure demonstrates how to process a request
  failure.

Closes #128
oleg-jukovec added a commit that referenced this issue Jun 28, 2023
- ExampleConnection_Do demonstrates how to process a result.
- ExampleConnection_Do_failure demonstrates how to process a request
  failure.

Closes #128
oleg-jukovec added a commit that referenced this issue Jun 28, 2023
- ExampleConnection_Do demonstrates how to process a result.
- ExampleConnection_Do_failure demonstrates how to process a request
  failure.

Closes #128
oleg-jukovec added a commit that referenced this issue Jun 29, 2023
- ExampleConnection_Do demonstrates how to process a result.
- ExampleConnection_Do_failure demonstrates how to process a request
  failure.

Closes #128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Improve code readability, simplify maintenance and so on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant