Fix many flaky tests on macOs #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
better0fdead
force-pushed
the
better0fdead/flaky-macOS
branch
from
9f64691
to
4af9157
Compare
better0fdead
force-pushed
the
better0fdead/flaky-macOS
branch
from
4af9157
to
48610d7
Compare
better0fdead
changed the title
better0fdead
force-pushed
the
better0fdead/flaky-macOS
branch
from
48610d7
to
df5cc74
Compare
better0fdead
force-pushed
the
better0fdead/flaky-macOS
branch
from
df5cc74
to
ab3b1fe
Compare
=( |
better0fdead
force-pushed
the
better0fdead/flaky-macOS
branch
from
ab3b1fe
to
fb21ba2
Compare
oleg-jukovec
force-pushed
the
better0fdead/flaky-macOS
branch
3 times, most recently
from
f3cdd6e
to
b542dd6
Compare
oleg-jukovec
added a commit
that referenced
this pull request
May 11, 2023
We should release the lock even if connect fails. Part of #281
oleg-jukovec
added a commit
that referenced
this pull request
May 11, 2023
oleg-jukovec
force-pushed
the
better0fdead/flaky-macOS
branch
from
b542dd6
to
4c177fb
Compare
oleg-jukovec
added a commit
that referenced
this pull request
May 11, 2023
oleg-jukovec
force-pushed
the
better0fdead/flaky-macOS
branch
from
4c177fb
to
2364035
Compare
oleg-jukovec
added a commit
that referenced
this pull request
May 11, 2023
oleg-jukovec
force-pushed
the
better0fdead/flaky-macOS
branch
from
2364035
to
adc6b51
Compare
oleg-jukovec
force-pushed
the
better0fdead/flaky-macOS
branch
10 times, most recently
from
0c0151f
to
45a88ec
Compare
oleg-jukovec
force-pushed
the
better0fdead/flaky-macOS
branch
from
45a88ec
to
f605a39
Compare
Ttr should be in seconds. Part of #278
We don't have stable results if queue.cfg({in_replicaset = true})
is called after box.cfg(). Probably it is expected [1].
1. tarantool/queue#206
Part of #278
We need to wait for an additional events to make the test stable: 1. A ready state for a queue. 2. A success queue configuration on all instances. 3. An available RW instance. 4. A success role switch. Closes #278
An instance was listening on a testing port until the configuration was complete. At the end of the configuration, the port was reopened. As a result, we saw connection loss in tests. Closes #288
oleg-jukovec
force-pushed
the
better0fdead/flaky-macOS
branch
from
f605a39
to
d3b5fb3
Compare
oleg-jukovec
force-pushed
the
better0fdead/flaky-macOS
branch
from
d3b5fb3
to
1ce5c9e
Compare
|
I will re-open the pull request: I cannot assign @better0fdead to reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed many flaky tests for macOs. Unfortunately, I was unable to reproduce part 1 of #291. But this does not look critical and rarely occurs, let's wait repeating the problem for now.
I didn't forget about (remove if it is not applicable):
Related issues:
Closes #277
Closes #278
Closes #282
Closes #288
Part of #291