-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: support IPROTO_WATCH_ONCE
request type
#340
api: support IPROTO_WATCH_ONCE
request type
#340
Conversation
e6775db
to
7320b05
Compare
You also forgot to update client features list: Lines 76 to 98 in b6e8aba
I also suggest to replace Lines 14 to 74 in b6e8aba
By the type |
b978024
to
2a378a6
Compare
Updated |
2a378a6
to
3009903
Compare
b6b3ca7
to
fd987e5
Compare
31b1426
to
b9febd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the patch!
b9febd3
to
428e050
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, see a couple of nits regarding the description below
428e050
to
43ff73d
Compare
Please check what is wrong with |
Oh, please just rebase to the master branch: |
43ff73d
to
a916922
Compare
Added support of
IPROTO_WATCH_ONCE
request type.It works only for Tarantool version >= 3.0.0-alpha1.
Replaced the local
ProtocolFeature
type with theiproto.Feature
.Replaced local
Feature
constants with theiriproto.IPROTO_FEATURE_
analogues.I didn't forget about (remove if it is not applicable):
Closes #337