api: write a connection schema getter #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oleg-jukovec
left a comment
oleg-jukovec
left a comment
There was a problem hiding this comment.
Apparently we had a misunderstanding.
I would like to see a separate public function that would returns the current-actual schema. It shouldn't return a schema used by the connection, but re-fetch an actual one. Something like Connection.loadSchema() in the current implementation.
DerekBum
force-pushed
the
DerekBum/gh-7-connection-schema-getter
branch
from
70fdc03 to
92fe8b5
Compare
DerekBum
force-pushed
the
DerekBum/gh-7-connection-schema-getter
branch
3 times, most recently
from
66c5253 to
954c5b5
Compare
DerekBum
force-pushed
the
DerekBum/gh-7-connection-schema-getter
branch
4 times, most recently
from
663b54b to
7f0cffc
Compare
askalt
approved these changes
Nov 24, 2023
askalt
left a comment
askalt
left a comment
There was a problem hiding this comment.
Hi, thanks for the patch! See small comments below.
Also, please fix typo in commit message:
used needs to use -> one needs to use .
Write a helper function to load the actual schema for the user. Previously we stored actual schema in a private `schemaResolver` field and `Schema` field was used only to get a current schema. But now because of the new function, we don't need to store the `Schema` as a different field. So `Schema` was also removed. To update the schema, one needs to use `GetSchema` + `SetSchema` in pair. `SetSchema(Schema)` replacing the `OverrideSchema(*Schema)`. `Spaces` and `SpacesById` fields of the `Schema` struct store spaces by value. `Fields` and `FieldsById` fields of the `Space` struct store fields by value. `Index` and `IndexById` fields of the `Space` struct store indexes by value. `Fields` field of the `Index` struct store `IndexField` by value. Closes #7
DerekBum
force-pushed
the
DerekBum/gh-7-connection-schema-getter
branch
from
7f0cffc to
03e6c25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write a helper function to load the actual schema for the user.
Previously we stored actual schema in a private
schemaResolverfield andSchemafield was used only to get a current schema. But now because of the new function, we don't need to store theSchemaas a different field. SoSchemawas also removed.To update the schema, one needs to use
GetSchema+SetSchemain pair.SetSchema(Schema)replacing theOverrideSchema(*Schema).SpacesandSpacesByIdfields of theSchemastruct store spaces by value.FieldsandFieldsByIdfields of theSpacestruct store fields by value.IndexandIndexByIdfields of theSpacestruct store indexes by value.Fieldsfield of theIndexstruct storeIndexFieldby value.I didn't forget about (remove if it is not applicable):
Closes #7