Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connection: fix svacer issue #361

Merged
merged 1 commit into from
Dec 5, 2023
Merged

connection: fix svacer issue #361

merged 1 commit into from
Dec 5, 2023

Conversation

better0fdead
Copy link

Changed type of 'length' variable in 'read' function to avoid overflow when calculating it.

I didn't forget about (remove if it is not applicable):

  • [ not needed] Tests (see documentation for a testing package)
  • [not needed ] Changelog (see documentation for changelog format)
  • [not needed ] Documentation (see documentation for documentation style guide)

0x501D
0x501D approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@0x501D 0x501D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

oleg-jukovec
oleg-jukovec reviewed Dec 5, 2023
View reviewed changes
connection.go Outdated Show resolved Hide resolved
@better0fdead
connection: fix svacer issue
bfdca0e 
Changed type of 'length' variable in 'read' function to avoid overflow when calculating it.
@better0fdead better0fdead force-pushed the better0fdead/no-gh-svacer branch from 872001b to bfdca0e Compare December 5, 2023 12:30
oleg-jukovec
oleg-jukovec approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@oleg-jukovec oleg-jukovec merged commit 7d73f6a into master Dec 5, 2023
22 checks passed
@oleg-jukovec oleg-jukovec deleted the better0fdead/no-gh-svacer branch December 5, 2023 12:48
@oleg-jukovec oleg-jukovec mentioned this pull request Jan 10, 2024
Merged
oleg-jukovec added a commit that referenced this pull request Jan 10, 2024
@oleg-jukovec
Release 1.12.2
de8b005 
Overview

    The patch release imports fixes from the master branch.

Breaking changes

    There are no breaking changes in the release.

Bugfixes

    Potentially packet length overflow when reading (#361).
oleg-jukovec added a commit that referenced this pull request Jan 10, 2024
@oleg-jukovec
Release 1.12.2
db70651 
Overview

    The patch release imports fixes from the master branch.

Breaking changes

    There are no breaking changes in the release.

Bugfixes

    Tests with case sensitive SQL (#341).

    Potentially packet length overflow when reading (#361).
oleg-jukovec added a commit that referenced this pull request Jan 10, 2024
@oleg-jukovec
Release 1.12.2
a9d67bb 
Overview

    The patch release imports fixes from the master branch.

Breaking changes

    There are no breaking changes in the release.

Bugfixes

    Tests with crud 1.4.0 (#336).

    Tests with case sensitive SQL (#341).

    Potentially packet length overflow when reading (#361).
oleg-jukovec added a commit that referenced this pull request Jan 11, 2024
@oleg-jukovec
Release 1.12.2
6843830 
Overview

    The patch release imports fixes from the master branch.

Breaking changes

    There are no breaking changes in the release.

Bugfixes

    Tests with crud 1.4.0 (#336).

    Tests with case sensitive SQL (#341).

    Potentially packet length overflow when reading (#361).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-jukovec oleg-jukovec oleg-jukovec approved these changes

@0x501D 0x501D 0x501D approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@better0fdead @0x501D @oleg-jukovec