pool: add Instance type #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestConn_ReadWrite causes endless read/write in goroutines after execution of the test. The patch fixes the problem.
The type Instance:
```
type Instance struct {
// Name is an unique name of the instance.
Name string
// Dialer will be used to create a connection to the instance.
Dialer tarantool.Dialer
// Opts will be used to specify a connection options.
Opts tarantool.Opts
}
```
The type allows to specify a dialer and connection options per a
pool instance. It is used in `pool.Connect`, `pool.ConnectWithOpts`
and `pool.Add` to specify an instance configuration now.
Closes #356
DerekBum
approved these changes
Jan 26, 2024
oleg-jukovec
deleted the
oleg-jukovec/gh-356-pool-connect-update-interface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type Instance:
The type allows to specify a dialer and connection options per a pool instance. It is used in
pool.Connect,pool.ConnectWithOptsandpool.Addto specify an instance configuration now.Closes #356