api: remove ssl #379
Merged
api: remove ssl #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekBum
force-pushed
the
DerekBum/gh-301-remove-ssl
branch
from
9f8ea39 to
de0a46c
Compare
oleg-jukovec
reviewed
Feb 4, 2024
|
In the commit message: s/[1] https://github.com/tarantool/go-tlsdialer/1. https://github.com/tarantool/go-tlsdialer/ The commit message should be < 72 characters. Now it is too short at the first glance. |
DerekBum
force-pushed
the
DerekBum/gh-301-remove-ssl
branch
2 times, most recently
from
64ca4ce to
350de61
Compare
oleg-jukovec
approved these changes
Feb 5, 2024
DerekBum
force-pushed
the
DerekBum/gh-301-remove-ssl
branch
from
350de61 to
edc1a3e
Compare
oleg-jukovec
reviewed
Feb 8, 2024
DerekBum
force-pushed
the
DerekBum/gh-301-remove-ssl
branch
2 times, most recently
from
ba00d4e to
ae6cfc6
Compare
|
Please, |
That was already changed this morning. |
DerekBum
force-pushed
the
DerekBum/gh-301-remove-ssl
branch
from
ae6cfc6 to
00e72eb
Compare
CHANGELOG.md
Outdated
| @@ -125,6 +124,7 @@ Versioning](http://semver.org/spec/v2.0.0.html) except to the first release. | |||
| - Code() method from the Request interface (#158) | |||
| - `Schema` field from the `Connection` struct (#7) | |||
| - `OkCode` and `PushCode` constants (#237) | |||
| - Move SSL support to a separate module `go-tlsdialer` (#301) | |||
There was a problem hiding this comment.
It was simply
Removed
- IPROTO constants
for moving IPROTO constants to a separate package. I think here we too should simply
Removed
- SSL support (Disable SSL by default #301)
DifferentialOrange
approved these changes
Feb 8, 2024
`OpenSslDialer` and all of its helper functions and tests were rellocated to the `go-tlsdialer` [1] package (and renamed to `OpenSSLDialer`). So now we can safely remove all the copy-pasted code from `go-tarantool`. This way, in order to use SSL, user should import the `go-tlsdialer` package and call functions from there. 1. https://github.com/tarantool/go-tlsdialer/ Part of #301
DerekBum
force-pushed
the
DerekBum/gh-301-remove-ssl
branch
from
00e72eb to
dc85b64
Compare
After all Tarantool-EE specific logic was moved to the `go-tlsdialer` [1], Tarantool-EE jobs could be removed from ci workflows. This commit removes ci jobs for Tarantool-EE. 1. https://github.com/tarantool/go-tlsdialer/ Closes #301
DerekBum
force-pushed
the
DerekBum/gh-301-remove-ssl
branch
from
dc85b64 to
7fae859
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSslDialerand all of its helper functions and tests were rellocated to thego-tlsdialer[1] package (and renamed toOpenSSLDialer). So now we can safely remove all the copy-pasted code fromgo-tarantool.This way, in order to use SSL, user should import the
go-tlsdialerpackage and call functions from there.After all Tarantool-EE specific logic was moved to the
go-tlsdialer, Tarantool-EE jobs could be removed from ci workflows. In a separate commit, Tarantool-EE jobs are removed from the ci workflows.Related issues:
Closes #301