pool: removed deprecated methods #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermyar
force-pushed
the
ermyar/gh-478-removing-deprecated-pool-methods
branch
from
030b998 to
e02f318
Compare
oleg-jukovec
requested changes
Oct 31, 2025
oleg-jukovec
requested changes
Nov 1, 2025
There was a problem hiding this comment.
LGTM, but please add a note about the change into the migration guide:
https://github.com/tarantool/go-tarantool/blob/master/MIGRATION.md?plain=1#L9
ermyar
force-pushed
the
ermyar/gh-478-removing-deprecated-pool-methods
branch
from
e02f318 to
0839bd4
Compare
bigbes
approved these changes
Nov 2, 2025
Still relevant. |
oleg-jukovec
requested changes
Nov 2, 2025
ermyar
force-pushed
the
ermyar/gh-478-removing-deprecated-pool-methods
branch
from
0839bd4 to
021143a
Compare
ermyar
force-pushed
the
ermyar/gh-478-removing-deprecated-pool-methods
branch
from
021143a to
5ed5af6
Compare
Removed deprecated pool's methods. Related tests are updated (deleted or refactored). Also removed mentioned methods in interfaces declarations. Fixes #478
ermyar
force-pushed
the
ermyar/gh-478-removing-deprecated-pool-methods
branch
from
5ed5af6 to
1e2e17d
Compare
oleg-jukovec
approved these changes
Nov 3, 2025
oleg-jukovec
deleted the
ermyar/gh-478-removing-deprecated-pool-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed deprecated pool's methods. Related tests are updated (deleted or refactored). Also removed mentioned methods in interfaces declarations.
Fixes #478
I didn't forget about (remove if it is not applicable):