cd: publish rpm/deb packages on tag push #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/build folder will contain tmp files to build rpm/deb packages /packpack is a tool for building packages
artembo
force-pushed
the
artembo/packaging
branch
2 times, most recently
from
7f8ea3b to
2676e6a
Compare
Totktonada
reviewed
Jul 6, 2022
Totktonada
reviewed
Jul 6, 2022
artembo
force-pushed
the
artembo/packaging
branch
from
2676e6a to
c45bff4
Compare
Totktonada
reviewed
Jul 9, 2022
artembo
force-pushed
the
artembo/packaging
branch
2 times, most recently
from
63ec5a2 to
1ade115
Compare
|
@Totktonada many thanks for the help with Another issue is in --- a/debian/rules
+++ b/debian/rules
@@ -2,7 +2,6 @@
DEB_CMAKE_EXTRA_FLAGS := -DCMAKE_INSTALL_LIBDIR=lib/$(DEB_HOST_MULTIARCH) \
-DCMAKE_BUILD_TYPE=RelWithDebInfo
-DEB_MAKE_CHECK_TARGET := luatest
include /usr/share/cdbs/1/rules/debhelper.mk
include /usr/share/cdbs/1/class/cmake.mkFollowing the approach for |
At least until we'll package |
artembo
force-pushed
the
artembo/packaging
branch
from
1ade115 to
d5b8f69
Compare
|
See dry run of building packages by introduced workflow here |
artembo
force-pushed
the
artembo/packaging
branch
from
d5b8f69 to
f50e762
Compare
artembo
force-pushed
the
artembo/packaging
branch
2 times, most recently
from
83ab5dc to
32c5c2d
Compare
Totktonada
reviewed
Jul 13, 2022
Totktonada
reviewed
Jul 13, 2022
Totktonada
reviewed
Jul 13, 2022
Totktonada
reviewed
Jul 13, 2022
Totktonada
reviewed
Jul 13, 2022
Totktonada
reviewed
Jul 13, 2022
Totktonada
reviewed
Jul 13, 2022
artembo
force-pushed
the
artembo/packaging
branch
2 times, most recently
from
b10ae75 to
9f8f30a
Compare
artembo
force-pushed
the
artembo/packaging
branch
2 times, most recently
from
3fd6017 to
37341c1
Compare
Starting with fedora 33, the cmake build strategy has been changed to "out-of-source builds" by default (see [1]). Let's add support for the new behavior. Added `prebuild.sh` script with installation of Tarantool repo. `Packpack` performs building rpm packages in a clean docker container. The container must contain `luatest` to perform testing during the build as it was set by `-DCMAKE_BUILD_TYPE=RelWithDebInfo` cmake var. This cmake var was removed in this commit as well as `%check` phase. It's quite challenging to set up `luacheck` while the package is building and a bit useless because the module is tested in another job. [1] https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds Closes #165
artembo
force-pushed
the
artembo/packaging
branch
from
37341c1 to
31df980
Compare
`Packpack` installs dependencies using default apt repo. To provide the latest version of Tarantool 1.10 (the latest of the lower supported version), `prebuild.sh` script wich installs Tarantool repo was added to debian spec folder.
`Packpack` performs building rpm packages in a clean docker container. The container must contain `luatest` to perform testing during the build as it was set by `-DEB_MAKE_CHECK_TARGET := luatest` variable. It's quite challenging to set up `luacheck` while the package is building and a bit useless because the module is tested in another job. This commit removes testing http module during the build by `packpack`.
artembo
force-pushed
the
artembo/packaging
branch
2 times, most recently
from
602c34d to
6291dad
Compare
|
@Totktonada please review updated PR with resolving conversations if you are satisfied by the changes or answers. |
artembo
force-pushed
the
artembo/packaging
branch
2 times, most recently
from
4da3152 to
19a28bf
Compare
artembo
force-pushed
the
artembo/packaging
branch
2 times, most recently
from
08097f6 to
b66289b
Compare
Totktonada
reviewed
Jul 25, 2022
.github/workflows/packaging.yml
Outdated
| - { os: 'ubuntu', dist: 'bionic' } | ||
| - { os: 'ubuntu', dist: 'focal' } | ||
| - { os: 'ubuntu', dist: 'groovy' } | ||
| - { os: 'ubuntu', dist: 'hirsute' } |
There was a problem hiding this comment.
There was a problem hiding this comment.
These fails caused by disabling Ubuntu repositories of EOL hisrute and impish. @0x501D, can I remove these OS versions from the workflow?
There was a problem hiding this comment.
Yes, I see no reason to run CI on EOL distributions
Totktonada
approved these changes
Jul 25, 2022
artembo
force-pushed
the
artembo/packaging
branch
2 times, most recently
from
b66289b to
e440fa5
Compare
This workflow is intended to run on a tag push for creating and deploying module packages to S3 based repositories. Closes #163
artembo
force-pushed
the
artembo/packaging
branch
from
e440fa5 to
7a118a8
Compare
artembo
force-pushed
the
artembo/packaging
branch
from
81aa7f9 to
7a118a8
Compare
| - { os: 'ubuntu', dist: 'xenial' } | ||
| - { os: 'ubuntu', dist: 'bionic' } | ||
| - { os: 'ubuntu', dist: 'focal' } | ||
| - { os: 'ubuntu', dist: 'groovy' } |
This was referenced Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement GitHub Actions job which will publish rpm and deb packages for maintained operation systems.
The new workflow (packaging.yml) is intended to run on a tag push
for creating and deploying module packages to S3 based repositories.
Unfortunately,
Packpackcouldn't start without modification the httprepo.
Packpackperforms building rpm packages in a clean docker container.The container must contain
luatestto perform testing during thebuild as it was set by
-DEB_MAKE_CHECK_TARGET := luatestvariable.It's quite challenging to set up
luacheckwhile the package isbuilding and a bit useless because the module is tested in another job.
Added
prebuild.shscript for bothrpmanddebianwithinstallation of Tarantool repo.
Another issue is "out-of-source build" failure.
Starting with fedora 33, the
cmakebuild strategy has been changedto "out-of-source builds" by default (see [1]). Let's add support
for the new behaviour.