Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce, refactor logs #382

Closed
unera opened this issue Jun 17, 2024 · 2 comments · Fixed by #399
Closed

reduce, refactor logs #382

unera opened this issue Jun 17, 2024 · 2 comments · Fixed by #399
Assignees

Comments

@unera
Copy link

unera commented Jun 17, 2024

Now if I run a cluster that contains: 2 routers, 3 storages, 1 manager, etc I see all logs.
But all tests runs only one host! I want watching only test-flow from the host.

Note: From time to time I have 60-100 screens log-text about ONE FAILED TEST.

So, It would be nice:

  1. Hide all logs that generated by not luatest host
    • You can provide an option to show them, if a user wants
  2. Solve logs, that required :exec:
    • user must know about there are errors in them WITHOUT looking through logs prefixed as router 1 |, router 2 | etc
  3. All logs (that stores to /tmp/t) MUST NOT contain 'color' ESC-sequences (i.e. be grepable, printable through html, etc)

PS:

if I do

$ make test

and one test is failed, I want a mode that showes only reduced pass-failed log without spam about all problems and happen things in cluster that contains 10-20 nodes.

Please, provide an option to see what test is ok and what is failed. Let's full log be placed somewhere but not showed in terminal!

@unera
Copy link
Author

unera commented Jun 17, 2024

Положение (вводная, аксиома, итп):

Тесты одного файла исполняет один тарантул ($MAIN_HOST)

Выводы

  1. В большинстве случаев (кроме архисложных) логи прочих тарантулов только загромождают вывод (их вывод можно загнать в артефакт (отдельный файл) или под опцию
  2. тесты, что выполняются по exec можно всегда транслировать на $MAIN_HOST

@unera
Copy link
Author

unera commented Jun 17, 2024

There are 2 workflow

  1. Running test in CI. All host logs MUST be present in output
  2. Running test in terminal (by hand). All host logs aren't required in 99% cases. All host logs are spam in 99% cases!

locker added a commit to locker/tarantool-luatest that referenced this issue Oct 29, 2024
Unified logging is a fetaure that enables writing logs emitted by all
server instances instances and the luatest runner itself to a single
file. It's implemented by duplicating logs to stdout (using the tee
Linux command) and piping stdout to a log file in OutputBeautifier.
The OutputBeautifier still writes the logs to stdout, even if unified
logging is enabled. As a result, on any failure the runner spams stdout
with captured logs of started server instances. There's no need for
that because all logs can be read from the unified log file. It only
clutters the output making it difficult to figure out what went wrong.
So let's disable writing to stdout in OutputBeautifier if unified
logging is enabled.

No changelog because the feature was added by commit f8a1c10
("Add logging to unified file"), which hasn't been released yet.

Closes tarantool#382
@locker locker self-assigned this Oct 29, 2024
@locker locker closed this as completed in 8f87dd6 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants