Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process latency count more carefully #199

Closed
DifferentialOrange opened this issue Feb 19, 2021 · 3 comments · Fixed by #296
Closed

Process latency count more carefully #199

DifferentialOrange opened this issue Feb 19, 2021 · 3 comments · Fixed by #296
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@DifferentialOrange
Copy link
Member

If user forgets to return correct response object in HTTP handler, it results in "trying to subscribe nil" error in this line:

status = (not ok and 500) or result.status or 200,

We should process this more carefully. For example, throw explicit error("incorrect http handler").

@yngvar-antonsson yngvar-antonsson added the bug Something isn't working label Feb 20, 2021
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days

@github-actions github-actions bot added the Stale label Apr 21, 2021
@DifferentialOrange
Copy link
Member Author

Still relevant, I stepped on this mine once again in Monday

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants