CRUD CI started to fail

[DifferentialOrange]

tarantool/crud CI started to fail. Last success run was two weeks ago (nothing had changed since then).

Fails reproduces both on v1 and v2. Re-running with cache removed doesn't help.

CI fails are related to two reasons (they seems independent).

Wrong version

CI installs 2.6.0 instead of expected version.

Example:

Run tarantool/setup-tarantool@v2
  with:
    tarantool-version: 1.10.6
    nightly-build: false
Checking latest tarantool 1.10.6 version
  HTTP GET https://download.tarantool.org/tarantool/release/1.10/ubuntu/dists/jammy/main/binary-amd64/Packages
  
Cache not found for input key: tarantool-setup-jammy-
Adding gpg key
  HTTP GET https://download.tarantool.org/tarantool/release/1.10/gpgkey
  /usr/bin/sudo apt-key add -
  Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
  OK
Setting up repository
  /usr/bin/sudo tee /etc/apt/sources.list.d/tarantool.list
  deb https://download.tarantool.org/tarantool/release/1.10/ubuntu/ jammy main
Running apt-get update
  /usr/bin/sudo apt-get update
  Hit:1 http://azure.archive.ubuntu.com/ubuntu jammy InRelease
  Get:2 http://azure.archive.ubuntu.com/ubuntu jammy-updates InRelease [114 kB]
  Get:3 http://azure.archive.ubuntu.com/ubuntu jammy-backports InRelease [99.8 kB]
  Get:4 http://azure.archive.ubuntu.com/ubuntu jammy-security InRelease [110 kB]
  Get:5 https://packages.microsoft.com/ubuntu/22.04/prod jammy InRelease [10.5 kB]
  Get:6 http://azure.archive.ubuntu.com/ubuntu jammy-updates/main amd64 Packages [755 kB]
  Get:7 http://azure.archive.ubuntu.com/ubuntu jammy-updates/main Translation-en [169 kB]
  Get:8 http://azure.archive.ubuntu.com/ubuntu jammy-updates/main amd64 c-n-f Metadata [11.3 kB]
  Get:9 http://azure.archive.ubuntu.com/ubuntu jammy-updates/restricted amd64 Packages [475 kB]
  Get:10 http://azure.archive.ubuntu.com/ubuntu jammy-updates/restricted Translation-en [72.7 kB]
  Get:11 http://azure.archive.ubuntu.com/ubuntu jammy-updates/universe amd64 Packages [761 kB]
  Get:12 http://azure.archive.ubuntu.com/ubuntu jammy-updates/universe Translation-en [128 kB]
  Get:13 http://azure.archive.ubuntu.com/ubuntu jammy-updates/universe amd64 c-n-f Metadata [14.0 kB]
  Get:14 http://azure.archive.ubuntu.com/ubuntu jammy-updates/multiverse amd64 c-n-f Metadata [420 B]
  Get:15 http://azure.archive.ubuntu.com/ubuntu jammy-backports/universe amd64 Packages [6736 B]
  Get:16 http://azure.archive.ubuntu.com/ubuntu jammy-backports/universe Translation-en [9460 B]
  Get:17 http://azure.archive.ubuntu.com/ubuntu jammy-backports/universe amd64 c-n-f Metadata [348 B]
  Get:18 http://azure.archive.ubuntu.com/ubuntu jammy-security/main amd64 Packages [520 kB]
  Get:19 http://azure.archive.ubuntu.com/ubuntu jammy-security/main Translation-en [112 kB]
  Get:20 http://azure.archive.ubuntu.com/ubuntu jammy-security/main amd64 c-n-f Metadata [7200 B]
  Get:21 http://azure.archive.ubuntu.com/ubuntu jammy-security/restricted amd64 Packages [438 kB]
  Get:22 http://azure.archive.ubuntu.com/ubuntu jammy-security/restricted Translation-en [67.3 kB]
  Get:23 http://azure.archive.ubuntu.com/ubuntu jammy-security/restricted amd64 c-n-f Metadata [584 B]
  Get:24 http://azure.archive.ubuntu.com/ubuntu jammy-security/universe amd64 Packages [622 kB]
  Get:25 http://azure.archive.ubuntu.com/ubuntu jammy-security/universe Translation-en [81.5 kB]
  Get:26 http://azure.archive.ubuntu.com/ubuntu jammy-security/universe amd64 c-n-f Metadata [11.0 kB]
  Get:27 http://azure.archive.ubuntu.com/ubuntu jammy-security/multiverse amd64 c-n-f Metadata [228 B]
  Hit:28 https://ppa.launchpadcontent.net/ubuntu-toolchain-r/test/ubuntu jammy InRelease
  Get:29 https://packages.microsoft.com/ubuntu/22.04/prod jammy/main amd64 Packages [58.8 kB]
  Get:30 https://hb.bizmrg.com/tarantool_repo/release/1.10/ubuntu jammy InRelease [2871 B]
  Get:31 https://hb.bizmrg.com/tarantool_repo/release/1.10/ubuntu jammy/main amd64 Packages [1455 B]
  Get:32 https://hb.bizmrg.com/tarantool_repo/release/1.10/ubuntu jammy/main all Packages [1691 B]
  Fetched 4661 kB in 3s (1396 kB/s)
  Reading package lists...
  W: https://download.tarantool.org/tarantool/release/1.10/ubuntu/dists/jammy/InRelease: Key is stored in legacy trusted.gpg keyring (/etc/apt/trusted.gpg), see the DEPRECATION section in apt-key(8) for details.
Installing tarantool
  /usr/bin/sudo apt-get install -y tarantool=* tarantool-dev=*
  Reading package lists...
  Building dependency tree...
  Reading state information...
  The following additional packages will be installed:
    cmake cmake-data dh-elpa-helper libjsoncpp25 librhash0 tarantool-common
  Suggested packages:
    cmake-doc ninja-build cmake-format
  The following NEW packages will be installed:
    cmake cmake-data dh-elpa-helper libjsoncpp25 librhash0 tarantool
    tarantool-common tarantool-dev
  0 upgraded, 8 newly installed, 0 to remove and 37 not upgraded.
  Need to get 16.1 MB of archives.
  After this operation, 57.1 MB of additional disk space will be used.
  Get:1 http://azure.archive.ubuntu.com/ubuntu jammy/main amd64 libjsoncpp25 amd64 1.9.5-3 [80.0 kB]
  Get:2 http://azure.archive.ubuntu.com/ubuntu jammy/main amd64 librhash0 amd64 1.4.2-1ubuntu1 [125 kB]
  Get:3 http://azure.archive.ubuntu.com/ubuntu jammy/main amd64 dh-elpa-helper all 2.0.9ubuntu1 [7610 B]
  Get:4 http://azure.archive.ubuntu.com/ubuntu jammy-updates/main amd64 cmake-data all 3.22.1-1ubuntu1.22.04.1 [1913 kB]
  Get:5 http://azure.archive.ubuntu.com/ubuntu jammy-updates/main amd64 cmake amd64 3.22.1-1ubuntu1.22.04.1 [5013 kB]
  Get:6 http://azure.archive.ubuntu.com/ubuntu jammy/universe amd64 tarantool-common all 2.6.0-1ubuntu3 [27.8 kB]
  Get:7 http://azure.archive.ubuntu.com/ubuntu jammy/universe amd64 tarantool amd64 2.6.0-1ubuntu3 [8866 kB]
  Get:8 http://azure.archive.ubuntu.com/ubuntu jammy/universe amd64 tarantool-dev amd64 2.6.0-1ubuntu3 [28.5 kB]
  Fetched 16.1 MB in 0s (35.4 MB/s)
  Selecting previously unselected package libjsoncpp25:amd64.
  (Reading database ... 
  (Reading database ... 5%
  (Reading database ... 10%
  (Reading database ... 15%
  (Reading database ... 20%
  (Reading database ... 25%
  (Reading database ... 30%
  (Reading database ... 35%
  (Reading database ... 40%
  (Reading database ... 45%
  (Reading database ... 50%
  (Reading database ... 55%
  (Reading database ... 60%
  (Reading database ... 65%
  (Reading database ... 70%
  (Reading database ... 75%
  (Reading database ... 80%
  (Reading database ... 85%
  (Reading database ... 90%
  (Reading database ... 95%
  (Reading database ... 100%
  (Reading database ... 235876 files and directories currently installed.)
  Preparing to unpack .../0-libjsoncpp25_1.9.5-3_amd64.deb ...
  Unpacking libjsoncpp25:amd64 (1.9.5-3) ...
  Selecting previously unselected package librhash0:amd64.
  Preparing to unpack .../1-librhash0_1.4.2-1ubuntu1_amd64.deb ...
  Unpacking librhash0:amd64 (1.4.2-1ubuntu1) ...
  Selecting previously unselected package dh-elpa-helper.
  Preparing to unpack .../2-dh-elpa-helper_2.0.9ubuntu1_all.deb ...
  Unpacking dh-elpa-helper (2.0.9ubuntu1) ...
  Selecting previously unselected package cmake-data.
  Preparing to unpack .../3-cmake-data_3.22.1-1ubuntu1.22.04.1_all.deb ...
  Unpacking cmake-data (3.22.1-1ubuntu1.22.04.1) ...
  Selecting previously unselected package cmake.
  Preparing to unpack .../4-cmake_3.22.1-1ubuntu1.22.04.1_amd64.deb ...
  Unpacking cmake (3.22.1-1ubuntu1.22.04.1) ...
  Selecting previously unselected package tarantool-common.
  Preparing to unpack .../5-tarantool-common_2.6.0-1ubuntu3_all.deb ...
  Unpacking tarantool-common (2.6.0-1ubuntu3) ...
  Selecting previously unselected package tarantool.
  Preparing to unpack .../6-tarantool_2.6.0-1ubuntu3_amd64.deb ...
  Unpacking tarantool (2.6.0-1ubuntu3) ...
  Selecting previously unselected package tarantool-dev.
  Preparing to unpack .../7-tarantool-dev_2.6.0-1ubuntu3_amd64.deb ...
  Unpacking tarantool-dev (2.6.0-1ubuntu3) ...
  Setting up dh-elpa-helper (2.0.9ubuntu1) ...
  Setting up tarantool-common (2.6.0-1ubuntu3) ...
  Created symlink /etc/systemd/system/multi-user.target.wants/tarantool.service → /lib/systemd/system/tarantool.service.
  Setting up libjsoncpp25:amd64 (1.9.5-3) ...
  Setting up librhash0:amd64 (1.4.2-1ubuntu1) ...
  Setting up cmake-data (3.22.1-1ubuntu1.22.04.1) ...
  Setting up tarantool (2.6.0-1ubuntu3) ...
  update-alternatives: using /usr/bin/tarantool to provide /usr/bin/lua (lua-interpreter) in auto mode
  Setting up cmake (3.22.1-1ubuntu1.22.04.1) ...
  Setting up tarantool-dev (2.6.0-1ubuntu3) ...
  Processing triggers for man-db (2.10.2-1) ...
  Processing triggers for libc-bin (2.35-0ubuntu3.1) ...
  NEEDRESTART-VER: 3.5
  NEEDRESTART-KCUR: 5.15.0-1023-azure
  NEEDRESTART-KEXP: 5.15.0-1023-azure
  NEEDRESTART-KSTA: 1
Caching APT packages: cmake, cmake-data, dh-elpa-helper, libjsoncpp25:amd64, librhash0:amd64, tarantool, tarantool-common, tarantool-dev
/usr/bin/tar --posix --use-compress-program zstdmt -cf cache.tzst --exclude cache.tzst -P -C /home/runner/work/crud/crud --files-from manifest.txt
Failed to save: Unable to reserve cache with key tarantool-setup-jammy-, another job may be creating this cache. More details: Cache already exists. Scope: refs/heads/DifferentialOrange/run-ci, Key: tarantool-setup-jammy-, Version: e428007c66c0df647376688a257721b5ba2350f2c8549267dd9aec69f68b722d
Cache saved with key: tarantool-setup-jammy-
/usr/bin/tarantool --version
Tarantool 2.6.0-0-g47aa4e01e
Target: Linux-x86_64-RelWithDebInfo
Build options: cmake . -DCMAKE_INSTALL_PREFIX=/usr -DENABLE_BACKTRACE=ON
Compiler: /usr/bin/cc /usr/bin/g++
C_FLAGS:-g -O2 -ffile-prefix-map=/build/tarantool-yPWklf/tarantool-2.6.0=. -specs=/usr/share/dpkg/no-pie-compile.specs -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fexceptions -funwind-tables -fno-omit-frame-pointer -fno-stack-protector -fno-common -fopenmp -msse2 -std=c11 -Wall -Wextra -Wno-strict-aliasing -Wno-char-subscripts -Wno-format-truncation -Wno-gnu-alignof-expression -fno-gnu89-inline -Wno-cast-function-type
CXX_FLAGS:-g -O2 -ffile-prefix-map=/build/tarantool-yPWklf/tarantool-2.6.0=. -specs=/usr/share/dpkg/no-pie-compile.specs -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fexceptions -funwind-tables -fno-omit-frame-pointer -fno-stack-protector -fno-common -fopenmp -msse2 -std=c++11 -Wall -Wextra -Wno-strict-aliasing -Wno-char-subscripts -Wno-format-truncation -Wno-invalid-offsetof -Wno-gnu-alignof-expression -Wno-cast-function-type

Examples of failed arguments:

• tarantool-version: 1.10.6
• tarantool-version: 2.2
• tarantool-version: 2.3
• tarantool-version: 2.4
• tarantool-version: 2.5
• tarantool-version: 2.6 (expected latest 2.6.x)
• tarantool-version: 2.7
• tarantool-version: 2.8

Works fine:

• tarantool-version: 1.10
• tarantool-version: 2.10

tarantoolctl fatal error

tarantoolctl for successfully installed latest 1.10 not works.

Example:

Run tarantool --version
  tarantool --version
  ./deps.sh
  shell: /usr/bin/bash -e {0}
Tarantool 1.10.14-0-g95447943d
Target: Linux-x86_64-RelWithDebInfo
Build options: cmake . -DCMAKE_INSTALL_PREFIX=/usr -DENABLE_BACKTRACE=ON
Compiler: /usr/bin/cc /usr/lib/ccache/g++
C_FLAGS:-g -O2 -ffile-prefix-map=/build/tarantool-1.10.14.0=. -specs=/usr/share/dpkg/no-pie-compile.specs -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fexceptions -funwind-tables -fno-omit-frame-pointer -fno-stack-protector -fno-common -fopenmp -msse2 -std=c11 -Wall -Wextra -Wno-strict-aliasing -Wno-char-subscripts -Wno-format-truncation -Wno-gnu-alignof-expression -fno-gnu89-inline -Wno-cast-function-type
CXX_FLAGS:-g -O2 -ffile-prefix-map=/build/tarantool-1.10.14.0=. -specs=/usr/share/dpkg/no-pie-compile.specs -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fexceptions -funwind-tables -fno-omit-frame-pointer -fno-stack-protector -fno-common -fopenmp -msse2 -std=c++11 -Wall -Wextra -Wno-strict-aliasing -Wno-char-subscripts -Wno-format-truncation -Wno-invalid-offsetof -Wno-gnu-alignof-expression -Wno-cast-function-type
LuajitError: /usr/bin/tarantoolctl:923: module 'luarocks.core.cfg' not found:
	no field package.preload['luarocks.core.cfg']
	no file './luarocks/core/cfg.lua'
	no file './luarocks/core/cfg/init.lua'
	no file './luarocks/core/cfg.so'
	no file '/home/runner/work/crud/crud/.rocks/share/tarantool/luarocks/core/cfg.lua'
	no file '/home/runner/work/crud/crud/.rocks/share/tarantool/luarocks/core/cfg/init.lua'
	no file '/home/runner/work/crud/.rocks/share/tarantool/luarocks/core/cfg.lua'
	no file '/home/runner/work/crud/.rock
fatal error, exiting the event loop
Error: Process completed with exit code 1.

It is likely that this issue is not related directly to setup action. but I don't know where to start.

Workflow example: https://github.com/tarantool/crud/actions/runs/3601117234

[DifferentialOrange]

It seems that it could be related to ubuntu-latest changing from ubuntu-20.04 to ubuntu-22.04

[Totktonada]

@DifferentialOrange Thank you for the report! You're lucky man :)

Let's analyze both problems.

Ubuntu Jammy and Tarantool 1.10.6

We're run on Ubuntu Jammy (ubuntu-22.04 or ubuntu-latest, see here and here).

Run tarantool/setup-tarantool@v2
with:
tarantool-version: 1.10.6
nightly-build: false

<...>

/usr/bin/sudo apt-get install -y tarantool=* tarantool-dev=*

There is no Ubuntu Jammy build for Tarantool 1.10.6. Tarantool 1.10.14 is the first 1.10 release with Ubuntu Jammy builds (see tarantool/tarantool#7199).

The problem is that the action doesn't fail when there is no requested tarantool version.

I also think that we should offer a list of available Tarantool versions for given Ubuntu versions in the README.

NB: Add a test that receives an error on a non-existing version.

tarantoolctl on 1.10.14

Yeah, another incarnation of tarantool/tarantool#5429. I have added an explanation about 1.10.14 on Debian Bullseye (11) and Ubuntu Jammy (22.04) into that issue.

We should install specific tarantool-common version here:

setup-tarantool/src/main.ts

Lines 211 to 213 in 615e8f4

	await exec.exec(
	`sudo apt-get install -y tarantool=${version}* tarantool-dev=${version}*`
	)

NB: Add a test with 1.10.14 on ubuntu-22.04 and tarantoolctl rocks usage.

It seems, we also should pin origin for all three packages to prevent a next apt-get upgrade to replace them with distribution provided packages (see tarantool/installer.sh#11 for details).

NB: Add apt-get upgrade after the action call for 1.10.14 on Ubuntu Jammy (non-cached and cached both). OTOH, if we'll pin only origin, it is legal to update this package to 1.10.15 and beyond. Should we pin the version too?

[DifferentialOrange]

NB: Add apt-get upgrade after the action call for 1.10.14 on Ubuntu Jammy (non-cached and cached both). OTOH, if we'll pin only origin, it is legal to update this package to 1.10.15 and beyond. Should we pin the version too?

To be honest, I don't get what the question is. Are there some troubles with solving this for 1.10 condition (which is essentially 1.10-latest)?

[Totktonada]

I doubt that apt-get upgrade has much sense within a virtual runner, so maybe I'll just skip this problem (will not pin anything).